Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Diffing_Engine: Fix incorrect method reporting in IDiffing() #2899

Merged
merged 1 commit into from
Sep 1, 2022

Conversation

alelom
Copy link
Member

@alelom alelom commented Aug 30, 2022

Issues addressed by this PR

Closes #2898

Test files

See #2898

Changelog

Additional comments

@alelom alelom self-assigned this Aug 30, 2022
@alelom alelom added size:S Measured in minutes type:bug Error or unexpected behaviour labels Aug 30, 2022
Copy link
Contributor

@IsakNaslundBh IsakNaslundBh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code change looks good, and makes sense. As long as the bot comes through ok this can be merged safely.

@IsakNaslundBh
Copy link
Contributor

@BHoMBot check required

@bhombot-ci
Copy link

bhombot-ci bot commented Aug 30, 2022

@IsakNaslundBh to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check core
  • check null-handling
  • check serialisation
  • check versioning
  • check installer

@FraserGreenroyd
Copy link
Contributor

@BHoMBot check copyright-compliance
@BHoMBot check dataset-compliance
@BHoMBot check unit-tests
@BHoMBot check ready-to-merge

@bhombot-ci
Copy link

bhombot-ci bot commented Sep 1, 2022

@FraserGreenroyd to confirm, the following actions are now queued:

  • check copyright-compliance
  • check dataset-compliance
  • check unit-tests
  • check ready-to-merge

There are 9 requests in the queue ahead of you.

@IsakNaslundBh IsakNaslundBh merged commit daecd1b into main Sep 1, 2022
@IsakNaslundBh IsakNaslundBh deleted the Diffing_Engine-#2898-incorrectErrorReporting branch September 1, 2022 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size:S Measured in minutes type:bug Error or unexpected behaviour
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Diffing_Engine: incorrect error reporting
3 participants