Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Geometry_Engine: implement GeometryHash #2929

Merged
merged 48 commits into from
Nov 17, 2022
Merged

Conversation

alelom
Copy link
Member

@alelom alelom commented Oct 19, 2022

Issues addressed by this PR

Closes #2928

Test files

https://burohappold.sharepoint.com/:f:/s/BHoM/EjL3UGZ1dPNJtyv8RSTZsLYBktwHrwDwRjxsNqh6aJPQrw?e=EDxHzY

Changelog

Additional comments

@alelom alelom self-assigned this Oct 26, 2022
@alelom alelom added the type:feature New capability or enhancement label Oct 26, 2022
@alelom alelom marked this pull request as ready for review October 26, 2022 10:52
Copy link
Member

@al-fisher al-fisher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @alelom - looking good!
See comments below regarding PolySurface

Geometry_Engine/Query/GeometryHash.cs Outdated Show resolved Hide resolved
Geometry_Engine/Query/GeometryHash.cs Outdated Show resolved Hide resolved
alelom and others added 2 commits October 27, 2022 08:24
Co-authored-by: Al Fisher <al.fisher@burohappold.com>
@alelom alelom requested a review from al-fisher October 27, 2022 07:28
@al-fisher al-fisher dismissed their stale review October 27, 2022 09:50

Thanks @alelom - tweaks look good

Copy link
Contributor

@IsakNaslundBh IsakNaslundBh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few additional comments

Geometry_Engine/Query/GeometryHash.cs Outdated Show resolved Hide resolved
Geometry_Engine/Query/GeometryHash.cs Show resolved Hide resolved
Geometry_Engine/Query/GeometryHash.cs Outdated Show resolved Hide resolved
Geometry_Engine/Query/GeometryHash.cs Show resolved Hide resolved
Geometry_Engine/Query/GeometryHash.cs Outdated Show resolved Hide resolved
alelom and others added 4 commits October 27, 2022 16:10
Co-authored-by: Isak Näslund <isak.naslund@burohappold.com>
Co-authored-by: Isak Näslund <isak.naslund@burohappold.com>
Co-authored-by: Isak Näslund <isak.naslund@burohappold.com>
IsakNaslundBh
IsakNaslundBh previously approved these changes Nov 9, 2022
Copy link
Contributor

@IsakNaslundBh IsakNaslundBh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy with this now. Have made a few tests:

  • Different line representations (line, polyline, nurbscurve with two ctrlPts) as well as Polycurves consisting of the above all coming out the same
  • AS above for polylines working fine
  • Moving Complex NurbsSurface and checking the hash, works fine
  • Moving a Panel and checking the result
  • UT covers most base cases.

Code looks sensible and have had quite deep discussion about the implementation for most types.

Approved

@IsakNaslundBh
Copy link
Contributor

@BHoMBot check compliance
@BHoMBot check unit-tests

@bhombot-ci
Copy link

bhombot-ci bot commented Nov 9, 2022

@IsakNaslundBh to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check branch-compliance
  • check dataset-compliance
  • check copyright-compliance
  • check unit-tests

There are 19 requests in the queue ahead of you.

@IsakNaslundBh
Copy link
Contributor

@BHoMBot check required

@bhombot-ci
Copy link

bhombot-ci bot commented Nov 9, 2022

@IsakNaslundBh to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check core
  • check null-handling
  • check serialisation
  • check versioning
  • check installer

There are 6 requests in the queue ahead of you.

@bhombot-ci
Copy link

bhombot-ci bot commented Nov 9, 2022

The check documentation-compliance has already been run previously and recorded as a successful check. This check has not been run again at this time.

@bhombot-ci
Copy link

bhombot-ci bot commented Nov 9, 2022

The check installer has already been run previously and recorded as a successful check. This check has not been run again at this time.

@alelom
Copy link
Member Author

alelom commented Nov 17, 2022

@BHoMBot check required

@alelom
Copy link
Member Author

alelom commented Nov 17, 2022

@BHoMBot check compliance
@BHoMBot check unit-tests

@IsakNaslundBh
Copy link
Contributor

@BHoMBot check required

@bhombot-ci
Copy link

bhombot-ci bot commented Nov 17, 2022

@IsakNaslundBh to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check core
  • check null-handling
  • check serialisation
  • check versioning
  • check installer

@bhombot-ci
Copy link

bhombot-ci bot commented Nov 17, 2022

The check installer has already been run previously and recorded as a successful check. This check has not been run again at this time.

@IsakNaslundBh
Copy link
Contributor

@BHoMBot check copyright-compliance
@BHoMBot check dataset-compliance
@BHoMBot check unit-tests

@bhombot-ci
Copy link

bhombot-ci bot commented Nov 17, 2022

@IsakNaslundBh to confirm, the following actions are now queued:

  • check copyright-compliance
  • check dataset-compliance
  • check unit-tests

Copy link
Contributor

@IsakNaslundBh IsakNaslundBh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Null handling correctly added and checked for.

Re-approving.

@IsakNaslundBh
Copy link
Contributor

Null-handling failure is due to this PR being behind main, where another method has been fixed and merged in. Will dispensate as this is the only failure.

Will also dispensate code-compliance as agreed with @FraserGreenroyd in thread above.

@IsakNaslundBh
Copy link
Contributor

@BHoMBot check ready-to-merge

@bhombot-ci
Copy link

bhombot-ci bot commented Nov 17, 2022

@IsakNaslundBh to confirm, the following actions are now queued:

  • check ready-to-merge

There are 6 requests in the queue ahead of you.

@bhombot-ci
Copy link

bhombot-ci bot commented Nov 17, 2022

FAO: @FraserGreenroyd
@IsakNaslundBh is seeking dispensation on this Pull Request to skip a required check. Please can you provide authorisation for the check to be skipped, or provide assistance as appropriate.

The check they wish to have dispensation on is null-handling.

If you are providing dispensation on this occasion, please reply with:

@BHoMBot this is a DevOps instruction. I am authorising dispensation to be granted on check ref. 9549259727

@bhombot-ci
Copy link

bhombot-ci bot commented Nov 17, 2022

FAO: @FraserGreenroyd
@IsakNaslundBh is seeking dispensation on this Pull Request to skip a required check. Please can you provide authorisation for the check to be skipped, or provide assistance as appropriate.

The check they wish to have dispensation on is code-compliance.

If you are providing dispensation on this occasion, please reply with:

@BHoMBot this is a DevOps instruction. I am authorising dispensation to be granted on check ref. 9549222836

@IsakNaslundBh
Copy link
Contributor

@BHoMBot this is a DevOps instruction. I am authorising dispensation to be granted on check ref. 9549259727

@bhombot-ci
Copy link

bhombot-ci bot commented Nov 17, 2022

@IsakNaslundBh I have now provided a passing check on reference 9549259727 as requested.

@IsakNaslundBh
Copy link
Contributor

@BHoMBot this is a DevOps instruction. I am authorising dispensation to be granted on check ref. 9549222836

@bhombot-ci
Copy link

bhombot-ci bot commented Nov 17, 2022

@IsakNaslundBh I have now provided a passing check on reference 9549222836 as requested.

@IsakNaslundBh IsakNaslundBh merged commit dfedcdb into main Nov 17, 2022
@IsakNaslundBh IsakNaslundBh deleted the #2928-GeometryHash branch November 17, 2022 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:feature New capability or enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Geometry_Engine: Implement GeometryHash
4 participants