Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Environment_Engine: Add IsValid check for spaces #2952

Merged
merged 6 commits into from
Nov 25, 2022

Conversation

kprusicka
Copy link
Contributor

Issues addressed by this PR

Closes #2701

Test files

Changelog

Additional comments

Copy link
Contributor

@FraserGreenroyd FraserGreenroyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a great start @kprusicka. See comments on the code for feedback and improvements, mostly on enhancing what the user can do by exposing some tolerance settings 😄

Environment_Engine/Query/IsValid.cs Outdated Show resolved Hide resolved
Environment_Engine/Query/IsValid.cs Outdated Show resolved Hide resolved
Environment_Engine/Query/IsValid.cs Outdated Show resolved Hide resolved
Environment_Engine/Query/IsValid.cs Outdated Show resolved Hide resolved
Environment_Engine/Query/IsValid.cs Outdated Show resolved Hide resolved
Environment_Engine/Query/IsValid.cs Outdated Show resolved Hide resolved
Environment_Engine/Query/IsValid.cs Outdated Show resolved Hide resolved
Co-authored-by: Fraser Greenroyd <fraser.greenroyd@burohappold.com>
@FraserGreenroyd FraserGreenroyd added the type:feature New capability or enhancement label Nov 24, 2022
@FraserGreenroyd FraserGreenroyd changed the title IsValid file Environment_Engine: Add IsValid check for spaces Nov 24, 2022
Copy link
Contributor

@FraserGreenroyd FraserGreenroyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking great @kprusicka - nice work! Just one minor bit of documentation needed and a null-handling addition and then we should be good to go 😄

Environment_Engine/Query/IsValid.cs Show resolved Hide resolved
Environment_Engine/Query/IsValid.cs Show resolved Hide resolved
Environment_Engine/Query/IsValid.cs Show resolved Hide resolved
@FraserGreenroyd
Copy link
Contributor

@BHoMBot check compliance

@bhombot-ci
Copy link

bhombot-ci bot commented Nov 24, 2022

@FraserGreenroyd to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check branch-compliance
  • check dataset-compliance
  • check copyright-compliance

There are 63 requests in the queue ahead of you.

@bhombot-ci
Copy link

bhombot-ci bot commented Nov 25, 2022

@kprusicka fix requested for adding documentation punctuation.

The documentation attributes missing punctuation have been recorded as annotations on the checks tab.

I will add a full stop (.) to the end of any documentation within the changed files which does not currently end in a suitable piece of punctuation. If you want to perform the fixes in a different manner please resolve this manually and rerun the check.

If you are happy for me to go ahead and perform this action, please reply with:

@BHoMBot fix documentation punctuation ref. 9697261809

@FraserGreenroyd
Copy link
Contributor

@BHoMBot fix documentation punctuation ref. 9697261809

@bhombot-ci
Copy link

bhombot-ci bot commented Nov 25, 2022

@FraserGreenroyd I have queued up your request to fix documentation punctuation. There are 0 requests in the queue ahead of you.

@bhombot-ci
Copy link

bhombot-ci bot commented Nov 25, 2022

@FraserGreenroyd I am now going to add full stops (.) to documentation attributes in accordance with the annotations previously made.

@bhombot-ci
Copy link

bhombot-ci bot commented Nov 25, 2022

@FraserGreenroyd to confirm I have now resolved the documentation punctuation and pushed a commit to this Pull Request.

kprusicka and others added 2 commits November 25, 2022 10:04
Co-authored-by: Fraser Greenroyd <fraser.greenroyd@burohappold.com>
@FraserGreenroyd
Copy link
Contributor

@BHoMBot check compliance
@BHoMBot check null-handling

@bhombot-ci
Copy link

bhombot-ci bot commented Nov 25, 2022

@FraserGreenroyd to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check branch-compliance
  • check dataset-compliance
  • check copyright-compliance
  • check null-handling

@FraserGreenroyd
Copy link
Contributor

@BHoMBot check serialisation
@BHoMBot check core
@BHoMBot check versioning
@BHoMBot check unit-tests

@bhombot-ci
Copy link

bhombot-ci bot commented Nov 25, 2022

@FraserGreenroyd to confirm, the following actions are now queued:

  • check serialisation
  • check core
  • check versioning
  • check unit-tests

There are 17 requests in the queue ahead of you.

Copy link
Contributor

@FraserGreenroyd FraserGreenroyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything has now been addressed and this works well, great work @kprusicka

@FraserGreenroyd
Copy link
Contributor

@BHoMBot check ready-to-merge

@bhombot-ci
Copy link

bhombot-ci bot commented Nov 25, 2022

@FraserGreenroyd to confirm, the following actions are now queued:

  • check ready-to-merge

@FraserGreenroyd FraserGreenroyd merged commit 0d97666 into main Nov 25, 2022
@FraserGreenroyd FraserGreenroyd deleted the Environment_Engine-#2701-SpaceCheck branch November 25, 2022 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:feature New capability or enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Environment_Engine: Space Checking Method
3 participants