-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Environment_Engine: Add IsValid check for spaces #2952
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a great start @kprusicka. See comments on the code for feedback and improvements, mostly on enhancing what the user can do by exposing some tolerance settings 😄
Co-authored-by: Fraser Greenroyd <fraser.greenroyd@burohappold.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is looking great @kprusicka - nice work! Just one minor bit of documentation needed and a null-handling addition and then we should be good to go 😄
@BHoMBot check compliance |
@FraserGreenroyd to confirm, the following actions are now queued:
There are 63 requests in the queue ahead of you. |
@kprusicka fix requested for adding documentation punctuation. The documentation attributes missing punctuation have been recorded as annotations on the checks tab. I will add a full stop ( If you are happy for me to go ahead and perform this action, please reply with:
|
@BHoMBot fix documentation punctuation ref. 9697261809 |
@FraserGreenroyd I have queued up your request to fix documentation punctuation. There are 0 requests in the queue ahead of you. |
@FraserGreenroyd I am now going to add full stops ( |
@FraserGreenroyd to confirm I have now resolved the documentation punctuation and pushed a commit to this Pull Request. |
Co-authored-by: Fraser Greenroyd <fraser.greenroyd@burohappold.com>
@FraserGreenroyd to confirm, the following actions are now queued:
|
@FraserGreenroyd to confirm, the following actions are now queued:
There are 17 requests in the queue ahead of you. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything has now been addressed and this works well, great work @kprusicka
@BHoMBot check ready-to-merge |
@FraserGreenroyd to confirm, the following actions are now queued:
|
Issues addressed by this PR
Closes #2701
Test files
Changelog
Additional comments