-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Facade_Engine: Update Methods to Handle UValueCavity Fragment #2955
Facade_Engine: Update Methods to Handle UValueCavity Fragment #2955
Conversation
UValue AW methods updated to handle cavity u-value and continuous u-value
@BHoMBot check compliance |
@enarhi to confirm, the following actions are now queued:
|
@BHoMBot check required |
@enarhi to confirm, the following actions are now queued:
|
The check |
The check |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Tested using provided test script for all possible U Value combos for panels and openings per the script, and all results and error handling were as expected. Tested tweaking values along the way as well to confirm functionality for various result value combos.
The check |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we get some unit tests for new features added please 😄
@BHoMBot check compliance |
@enarhi to confirm, the following actions are now queued:
|
@BHoMBot check unit-tests |
@enarhi to confirm, the following actions are now queued:
There are 7 requests in the queue ahead of you. |
@BHoMBot check required |
@enarhi to confirm, the following actions are now queued:
There are 4 requests in the queue ahead of you. |
The check |
The check |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM as per previous review and passing of appropriate relevant Unit Tests
The check |
@BHoMBot check ready-to-merge |
@enarhi to confirm, the following actions are now queued:
|
Issues addressed by this PR
Closes #2951
Test files
https://burohappold.sharepoint.com/:u:/r/sites/BHoM/02_Current/12_Scripts/03_Alpha/BHoM/BHoM_Engine/Facade_Engine/BHoM%20PR%20Test%20Files/Facade_Engine-Cavity%20Insulation%20Test%20File.gh?csf=1&web=1&e=H9metl