Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove 6.0 PreviousVersion Attributes #2979

Merged
merged 1 commit into from
Jan 5, 2023

Conversation

BHoMBot
Copy link
Member

@BHoMBot BHoMBot commented Jan 5, 2023

Remove 6.0 PreviousVersion Attributes and Versioning JSON files

@bhombot-ci
Copy link

bhombot-ci bot commented Jan 5, 2023

@BHoMBot just to let you know, I have provided a check-versioning result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @FraserGreenroyd on BHoM

@FraserGreenroyd FraserGreenroyd added the type:compliance Non-conforming to code guidelines label Jan 5, 2023
@FraserGreenroyd
Copy link
Contributor

@BHoMBot this is a DevOps instruction. I am requesting neutral checks on: code-compliance, core, dataset-compliance, documentation-compliance, null-handling, project-compliance, serialisation, unit-tests

@bhombot-ci
Copy link

bhombot-ci bot commented Jan 5, 2023

@FraserGreenroyd I have provided neutral checks to the checks requested. These checks will need to be run properly to obtain full results.

@FraserGreenroyd
Copy link
Contributor

@BHoMBot check copyright-compliance

@bhombot-ci
Copy link

bhombot-ci bot commented Jan 5, 2023

@FraserGreenroyd to confirm, the following actions are now queued:

  • check copyright-compliance

@bhombot-ci
Copy link

bhombot-ci bot commented Jan 5, 2023

@BHoMBot just to let you know, I have provided a check-installer result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @FraserGreenroyd on BHoM

Copy link
Contributor

@FraserGreenroyd FraserGreenroyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving based on bot checks and DevOps workflows

@bhombot-ci
Copy link

bhombot-ci bot commented Jan 5, 2023

@BHoMBot just to let you know, I have provided a check-ready-to-merge result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @FraserGreenroyd on BHoM

@FraserGreenroyd FraserGreenroyd merged commit e0be095 into develop Jan 5, 2023
@FraserGreenroyd FraserGreenroyd deleted the BHoM-#01-RemovePreviousVersion60 branch January 5, 2023 11:00
@bhombot-ci bhombot-ci bot mentioned this pull request Mar 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:compliance Non-conforming to code guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants