Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spatial_Engine: Add support for Cellular sections #3011

Merged

Conversation

IsakNaslundBh
Copy link
Contributor

@IsakNaslundBh IsakNaslundBh commented Mar 2, 2023

NOTE: Depends on

BHoM/BHoM#1486

Issues addressed by this PR

Adds initial methods supporting CellularSection classes added in oM.

Test files

https://burohappold.sharepoint.com/:f:/s/BHoM/Egum0nEYkI9LkPQ6ETB3SDYBd5H2x0SZhXBS9DVdz7K-Kg?e=9KCZ4i

Changelog

Additional comments

@IsakNaslundBh IsakNaslundBh added the type:feature New capability or enhancement label Mar 2, 2023
@IsakNaslundBh IsakNaslundBh self-assigned this Mar 2, 2023
@IsakNaslundBh IsakNaslundBh changed the title Spatial o m 1479 add support for cellular shape profiles Spatial_Engine: Add support for Cellular sections Mar 2, 2023
@IsakNaslundBh IsakNaslundBh marked this pull request as ready for review March 9, 2023 09:16
Copy link
Member

@peterjamesnugent peterjamesnugent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested with script, checked dimensions of openings (Sinusoidal needs a check for length) and changes implemented to put spacing in the Create methods instead of widthWebPost.

@IsakNaslundBh
Copy link
Contributor Author

@BHoMBot check compliance

@bhombot-ci
Copy link

bhombot-ci bot commented Mar 10, 2023

@IsakNaslundBh to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check branch-compliance
  • check dataset-compliance
  • check copyright-compliance

Copy link
Member

@peterjamesnugent peterjamesnugent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy that further commits have addressed changes I requested.

Copy link
Member

@peterjamesnugent peterjamesnugent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reapprove because of unit tests.

@IsakNaslundBh IsakNaslundBh force-pushed the Spatial_oM-1479-AddSupportForCellularShapeProfiles branch from 337ce8d to 8b042eb Compare March 10, 2023 15:01
@IsakNaslundBh
Copy link
Contributor Author

@BHoMBot check unit-tests

@bhombot-ci
Copy link

bhombot-ci bot commented Mar 10, 2023

@IsakNaslundBh to confirm, the following actions are now queued:

  • check unit-tests

There are 6 requests in the queue ahead of you.

@IsakNaslundBh
Copy link
Contributor Author

@BHoMBot check null-handling
@BHoMBot check compliance

@bhombot-ci
Copy link

bhombot-ci bot commented Mar 10, 2023

@IsakNaslundBh to confirm, the following actions are now queued:

  • check null-handling
  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check branch-compliance
  • check dataset-compliance
  • check copyright-compliance

There are 4 requests in the queue ahead of you.

Copy link
Member

@peterjamesnugent peterjamesnugent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reapprove.

@IsakNaslundBh
Copy link
Contributor Author

@BHoMBot check core
@BHoMBot check serialisation

@bhombot-ci
Copy link

bhombot-ci bot commented Mar 10, 2023

@IsakNaslundBh to confirm, the following actions are now queued:

  • check core
  • check serialisation

There are 10 requests in the queue ahead of you.

@bhombot-ci
Copy link

bhombot-ci bot commented Mar 10, 2023

@IsakNaslundBh just to let you know, I have provided a check-installer result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @IsakNaslundBh on BHoM

@bhombot-ci
Copy link

bhombot-ci bot commented Mar 10, 2023

@IsakNaslundBh just to let you know, I have provided a check-versioning result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @IsakNaslundBh on BHoM

@FraserGreenroyd
Copy link
Contributor

@BHoMBot this is a DevOps instruction. I am requesting neutral checks on: versioning, ready-to-merge

@bhombot-ci
Copy link

bhombot-ci bot commented Mar 10, 2023

@FraserGreenroyd I have provided neutral checks to the checks requested. These checks will need to be run properly to obtain full results.

@IsakNaslundBh IsakNaslundBh merged commit 6305ce4 into develop Mar 10, 2023
@IsakNaslundBh IsakNaslundBh deleted the Spatial_oM-1479-AddSupportForCellularShapeProfiles branch March 10, 2023 15:30
@bhombot-ci bhombot-ci bot mentioned this pull request Mar 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:feature New capability or enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants