-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Spatial_Engine: Add support for Cellular sections #3011
Spatial_Engine: Add support for Cellular sections #3011
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested with script, checked dimensions of openings (Sinusoidal needs a check for length) and changes implemented to put spacing
in the Create
methods instead of widthWebPost
.
Spatial_Engine/Create/ShapeProfiles/CellularProfile/CircularOpening.cs
Outdated
Show resolved
Hide resolved
Spatial_Engine/Create/ShapeProfiles/CellularProfile/CircularOpening.cs
Outdated
Show resolved
Hide resolved
Spatial_Engine/Create/ShapeProfiles/CellularProfile/HexagonalOpening.cs
Outdated
Show resolved
Hide resolved
Spatial_Engine/Create/ShapeProfiles/CellularProfile/SinusoidalOpening.cs
Outdated
Show resolved
Hide resolved
Spatial_Engine/Create/ShapeProfiles/CellularProfile/CircularOpening.cs
Outdated
Show resolved
Hide resolved
Structure_Engine/Create/SectionProperties/CellularSection/CellularSectionFromBaseSection.cs
Outdated
Show resolved
Hide resolved
Structure_Engine/Create/SectionProperties/CellularSection/CellularSectionFromBaseSection.cs
Outdated
Show resolved
Hide resolved
@BHoMBot check compliance |
@IsakNaslundBh to confirm, the following actions are now queued:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Happy that further commits have addressed changes I requested.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reapprove because of unit tests.
…her than MassPerMetre TO give a more accurate result for CellularSections
Better distributions of the curves
Co-authored-by: Peter Nugent <Peter.Nugent@burohappold.com>
This reverts commit 1578bc2.
337ce8d
to
8b042eb
Compare
@BHoMBot check unit-tests |
@IsakNaslundBh to confirm, the following actions are now queued:
There are 6 requests in the queue ahead of you. |
@IsakNaslundBh to confirm, the following actions are now queued:
There are 4 requests in the queue ahead of you. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reapprove.
@IsakNaslundBh to confirm, the following actions are now queued:
There are 10 requests in the queue ahead of you. |
@IsakNaslundBh just to let you know, I have provided a |
@IsakNaslundBh just to let you know, I have provided a |
@BHoMBot this is a DevOps instruction. I am requesting neutral checks on: versioning, ready-to-merge |
@FraserGreenroyd I have provided neutral checks to the checks requested. These checks will need to be run properly to obtain full results. |
NOTE: Depends on
BHoM/BHoM#1486
Issues addressed by this PR
Adds initial methods supporting CellularSection classes added in oM.
Test files
https://burohappold.sharepoint.com/:f:/s/BHoM/Egum0nEYkI9LkPQ6ETB3SDYBd5H2x0SZhXBS9DVdz7K-Kg?e=9KCZ4i
Changelog
Additional comments