Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove 6.1 PreviousVersion Attributes #3032

Merged
merged 1 commit into from
Mar 31, 2023

Conversation

bhombot-ci[bot]
Copy link

@bhombot-ci bhombot-ci bot commented Mar 31, 2023

Remove 6.1 PreviousVersion Attributes and Versioning JSON files

@FraserGreenroyd
Copy link
Contributor

@BHoMBot check versioning

@bhombot-ci
Copy link
Author

bhombot-ci bot commented Mar 31, 2023

@FraserGreenroyd to confirm, the following actions are now queued:

  • check versioning

@FraserGreenroyd FraserGreenroyd added the type:compliance Non-conforming to code guidelines label Mar 31, 2023
@FraserGreenroyd
Copy link
Contributor

@BHoMBot check code-compliance
@BHoMBot check copyright-compliance
@BHoMBot check core
@BHoMBot check documentation-compliance
@BHoMBot check project-compliance
@BHoMBot check serialisation
@BHoMBot check null-handling
@BHoMBot check unit-tests

@bhombot-ci
Copy link
Author

bhombot-ci bot commented Mar 31, 2023

@FraserGreenroyd to confirm, the following actions are now queued:

  • check code-compliance
  • check copyright-compliance
  • check core
  • check documentation-compliance
  • check project-compliance
  • check serialisation
  • check null-handling
  • check unit-tests

There are 9 requests in the queue ahead of you.

@bhombot-ci
Copy link
Author

bhombot-ci bot commented Mar 31, 2023

@bhombot-ci[bot] just to let you know, I have provided a check-installer result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @FraserGreenroyd on BHoM

@FraserGreenroyd
Copy link
Contributor

@BHoMBot check dataset-compliance

@bhombot-ci
Copy link
Author

bhombot-ci bot commented Mar 31, 2023

@FraserGreenroyd to confirm, the following actions are now queued:

  • check dataset-compliance

@bhombot-ci
Copy link
Author

bhombot-ci bot commented Mar 31, 2023

FAO: @FraserGreenroyd
@FraserGreenroyd is seeking dispensation on this Pull Request to skip a required check. Please can you provide authorisation for the check to be skipped, or provide assistance as appropriate.

The check they wish to have dispensation on is documentation-compliance.

If you are providing dispensation on this occasion, please reply with:

@BHoMBot this is a DevOps instruction. I am authorising dispensation to be granted on check ref. 12424068692

@FraserGreenroyd
Copy link
Contributor

@BHoMBot this is a DevOps instruction. I am authorising dispensation to be granted on check ref. 12424068692

@bhombot-ci
Copy link
Author

bhombot-ci bot commented Mar 31, 2023

@FraserGreenroyd I have now provided a passing check on reference 12424068692 as requested.

Copy link
Contributor

@FraserGreenroyd FraserGreenroyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code checked and attributes removed and checks are happy.

@bhombot-ci
Copy link
Author

bhombot-ci bot commented Mar 31, 2023

@bhombot-ci[bot] just to let you know, I have provided a check-ready-to-merge result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @FraserGreenroyd on BHoM

@FraserGreenroyd FraserGreenroyd merged commit d6c8dea into develop Mar 31, 2023
@FraserGreenroyd FraserGreenroyd deleted the BHoM-RemovePreviousVersion61 branch March 31, 2023 14:01
@bhombot-ci bhombot-ci bot mentioned this pull request Jun 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:compliance Non-conforming to code guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants