Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove invalid unit test dataset #3058

Merged
merged 1 commit into from
May 23, 2023

Conversation

FraserGreenroyd
Copy link
Contributor

Fixes #3057

@FraserGreenroyd FraserGreenroyd added the type:compliance Non-conforming to code guidelines label May 23, 2023
@FraserGreenroyd FraserGreenroyd self-assigned this May 23, 2023
@FraserGreenroyd
Copy link
Contributor Author

@BHoMBot check unit-tests

@bhombot-ci
Copy link

bhombot-ci bot commented May 23, 2023

@FraserGreenroyd to confirm, the following actions are now queued:

  • check unit-tests

@FraserGreenroyd
Copy link
Contributor Author

@BHoMBot check unit-tests

@bhombot-ci
Copy link

bhombot-ci bot commented May 23, 2023

@FraserGreenroyd to confirm, the following actions are now queued:

  • check unit-tests

@FraserGreenroyd
Copy link
Contributor Author

@BHoMBot check compliance
@BHoMBot check core
@BHoMBot check serialisation
@BHoMBot check null-handling
@BHoMBot check versioning

@bhombot-ci
Copy link

bhombot-ci bot commented May 23, 2023

@FraserGreenroyd to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check branch-compliance
  • check dataset-compliance
  • check copyright-compliance
  • check core
  • check serialisation
  • check null-handling
  • check versioning

@FraserGreenroyd
Copy link
Contributor Author

@BHoMBot this is a DevOps instruction. I am requesting neutral checks on: installer, dataset-compliance, ready-to-merge

@bhombot-ci
Copy link

bhombot-ci bot commented May 23, 2023

@FraserGreenroyd I have provided neutral checks to the checks requested. These checks will need to be run properly to obtain full results.

Copy link

@CKBoulter CKBoulter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dataset removed as required/explained by @FraserGreenroyd

@FraserGreenroyd FraserGreenroyd merged commit c1f8ef8 into develop May 23, 2023
@FraserGreenroyd FraserGreenroyd deleted the UnitTests-#3057-RemoveArchitectureTests branch May 23, 2023 11:28
@bhombot-ci bhombot-ci bot mentioned this pull request Jun 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:compliance Non-conforming to code guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Architecture Unit Tests
2 participants