Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.ci: Update unit tests following LCA refactor #3072

Merged
merged 1 commit into from
Jun 6, 2023

Conversation

FraserGreenroyd
Copy link
Contributor

Fixes #3065

Unit Tests that I can't upgrade have been removed with new issues raised for relevant individuals to resolve.

@FraserGreenroyd FraserGreenroyd added the type:bug Error or unexpected behaviour label Jun 6, 2023
@FraserGreenroyd FraserGreenroyd self-assigned this Jun 6, 2023
@FraserGreenroyd
Copy link
Contributor Author

@BHoMBot check unit-tests

@bhombot-ci
Copy link

bhombot-ci bot commented Jun 6, 2023

@FraserGreenroyd to confirm, the following actions are now queued:

  • check unit-tests

There are 23 requests in the queue ahead of you.

@FraserGreenroyd
Copy link
Contributor Author

@BHoMBot check compliance
@BHoMBot check required

@bhombot-ci
Copy link

bhombot-ci bot commented Jun 6, 2023

@FraserGreenroyd to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check branch-compliance
  • check dataset-compliance
  • check copyright-compliance
  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check core
  • check null-handling
  • check serialisation
  • check versioning
  • check installer

There are 12 requests in the queue ahead of you.

Copy link
Contributor

@desaiwangBH desaiwangBH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fraser talked me through the changes, and all makes sense.

@FraserGreenroyd
Copy link
Contributor Author

FraserGreenroyd commented Jun 6, 2023

@BHoMBot check ready-to-merge

@bhombot-ci
Copy link

bhombot-ci bot commented Jun 6, 2023

@FraserGreenroyd to confirm, the following actions are now queued:

  • check ready-to-merge

@FraserGreenroyd
Copy link
Contributor Author

@BHoMBot this is a DevOps instruction. I am requesting neutral checks on: unit-tests, dataset-compliance

@bhombot-ci
Copy link

bhombot-ci bot commented Jun 6, 2023

@FraserGreenroyd I have provided neutral checks to the checks requested. These checks will need to be run properly to obtain full results.

@FraserGreenroyd FraserGreenroyd merged commit 9d3b5b9 into develop Jun 6, 2023
@FraserGreenroyd FraserGreenroyd deleted the BHoM_Engine-#3065-UnitTests branch June 6, 2023 21:31
@bhombot-ci bhombot-ci bot mentioned this pull request Jun 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:bug Error or unexpected behaviour
Projects
None yet
Development

Successfully merging this pull request may close these issues.

An error occurred on a unit test
2 participants