Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Structure_Engine: Rename StartNode/EndNode to Start/End #3236

Merged
merged 5 commits into from
Jan 11, 2024
Merged

Structure_Engine: Rename StartNode/EndNode to Start/End #3236

merged 5 commits into from
Jan 11, 2024

Conversation

FraserGreenroyd
Copy link
Contributor

NOTE: Depends on

BHoM/BHoM#1579

Changelog

  • Update Analytical and Structure Engine based on property rename from StartNode to Start and from EndNode to End

@FraserGreenroyd FraserGreenroyd added the type:compliance Non-conforming to code guidelines label Jan 11, 2024
@FraserGreenroyd FraserGreenroyd self-assigned this Jan 11, 2024
@FraserGreenroyd
Copy link
Contributor Author

@BHoMBot check installer

@bhombot-ci BHoMBot-CI
Copy link

bhombot-ci bot commented Jan 11, 2024

@FraserGreenroyd to confirm, the following actions are now queued:

  • check installer

@FraserGreenroyd FraserGreenroyd added the status:do-not-merge For instance, test PR, for discussion, or dependant PRs not ready for merge label Jan 11, 2024
@FraserGreenroyd
Copy link
Contributor Author

@BHoMBot check installer

@bhombot-ci BHoMBot-CI
Copy link

bhombot-ci bot commented Jan 11, 2024

@FraserGreenroyd to confirm, the following actions are now queued:

  • check installer

@FraserGreenroyd
Copy link
Contributor Author

@BHoMBot check installer

@bhombot-ci BHoMBot-CI
Copy link

bhombot-ci bot commented Jan 11, 2024

@FraserGreenroyd to confirm, the following actions are now queued:

  • check installer

@FraserGreenroyd
Copy link
Contributor Author

@BHoMBot check versioning

@bhombot-ci BHoMBot-CI
Copy link

bhombot-ci bot commented Jan 11, 2024

@FraserGreenroyd to confirm, the following actions are now queued:

  • check versioning

@FraserGreenroyd
Copy link
Contributor Author

@BHoMBot check compliance
@BHoMBot check core
@BHoMBot check null-handling
@BHoMBot check serialisation

@bhombot-ci BHoMBot-CI
Copy link

bhombot-ci bot commented Jan 11, 2024

@FraserGreenroyd to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check branch-compliance
  • check dataset-compliance
  • check copyright-compliance
  • check core
  • check null-handling
  • check serialisation

There are 8 requests in the queue ahead of you.

@FraserGreenroyd
Copy link
Contributor Author

@BHoMBot check compliance

@bhombot-ci BHoMBot-CI
Copy link

bhombot-ci bot commented Jan 11, 2024

@FraserGreenroyd to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check branch-compliance
  • check dataset-compliance
  • check copyright-compliance

@FraserGreenroyd
Copy link
Contributor Author

@BHoMBot check versioning

@bhombot-ci BHoMBot-CI
Copy link

bhombot-ci bot commented Jan 11, 2024

@FraserGreenroyd to confirm, the following actions are now queued:

  • check versioning

There are 5 requests in the queue ahead of you.

@FraserGreenroyd
Copy link
Contributor Author

@BHoMBot check versioning

@bhombot-ci BHoMBot-CI
Copy link

bhombot-ci bot commented Jan 11, 2024

@FraserGreenroyd to confirm, the following actions are now queued:

  • check versioning

@FraserGreenroyd
Copy link
Contributor Author

@BHoMBot check versioning

@bhombot-ci BHoMBot-CI
Copy link

bhombot-ci bot commented Jan 11, 2024

@FraserGreenroyd to confirm, the following actions are now queued:

  • check versioning

@FraserGreenroyd
Copy link
Contributor Author

@BHoMBot check installer

@bhombot-ci BHoMBot-CI
Copy link

bhombot-ci bot commented Jan 11, 2024

@FraserGreenroyd to confirm, the following actions are now queued:

  • check installer

There are 73 requests in the queue ahead of you.

@FraserGreenroyd
Copy link
Contributor Author

@BHoMBot check core
@BHoMBot check null-handling
@BHoMBot check serialisation

@bhombot-ci BHoMBot-CI
Copy link

bhombot-ci bot commented Jan 11, 2024

@FraserGreenroyd to confirm, the following actions are now queued:

  • check core
  • check null-handling
  • check serialisation

There are 1 requests in the queue ahead of you.

@FraserGreenroyd FraserGreenroyd marked this pull request as ready for review January 11, 2024 15:50
@FraserGreenroyd FraserGreenroyd removed the status:do-not-merge For instance, test PR, for discussion, or dependant PRs not ready for merge label Jan 11, 2024
@FraserGreenroyd
Copy link
Contributor Author

@BHoMBot this is a DevOps instruction. I am requesting neutral checks on: unit-tests

@bhombot-ci BHoMBot-CI
Copy link

bhombot-ci bot commented Jan 11, 2024

@FraserGreenroyd I have provided neutral checks to the checks requested. These checks will need to be run properly to obtain full results.

Tom-Kingstone
Tom-Kingstone approved these changes Jan 11, 2024
View reviewed changes
Copy link
Contributor

@Tom-Kingstone Tom-Kingstone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, see message in linked PR.

@bhombot-ci BHoMBot-CI
Copy link

bhombot-ci bot commented Jan 11, 2024

@FraserGreenroyd just to let you know, I have provided a check-ready-to-merge result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @FraserGreenroyd on BHoM

@FraserGreenroyd FraserGreenroyd merged commit 3c81ed1 into develop Jan 11, 2024
13 checks passed
@FraserGreenroyd FraserGreenroyd deleted the Analytical_oM-#487-RenameProperties branch January 11, 2024 16:05
@bhombot-ci bhombot-ci bot mentioned this pull request Mar 11, 2024
Merged
IsakNaslundBh added a commit that referenced this pull request Apr 15, 2024
@IsakNaslundBh
Re-serialise and upgrade all structural test-sets
79931e0 
Many behind the upgrade from removing the Node name from start end performed in #3236
Simply re-serialising all of them to make sure they are up to date and do not need versioning to deserialise
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tom-Kingstone Tom-Kingstone Tom-Kingstone approved these changes

@IsakNaslundBh IsakNaslundBh Awaiting requested review from IsakNaslundBh IsakNaslundBh is a code owner

@rwemay rwemay Awaiting requested review from rwemay rwemay is a code owner

@al-fisher al-fisher Awaiting requested review from al-fisher al-fisher is a code owner

Assignees

@FraserGreenroyd FraserGreenroyd

Labels
type:compliance Non-conforming to code guidelines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@FraserGreenroyd @Tom-Kingstone