Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BHoM_Engine: wrapping fixed in ShiftList method #3274

Merged
merged 1 commit into from
Feb 2, 2024

Conversation

pawelbaran
Copy link
Member

@pawelbaran pawelbaran commented Feb 2, 2024

Issues addressed by this PR

Closes #3273

Test files

On SharePoint

Changelog

Additional comments

@pawelbaran pawelbaran added the type:bug Error or unexpected behaviour label Feb 2, 2024
@pawelbaran pawelbaran self-assigned this Feb 2, 2024
@pawelbaran
Copy link
Member Author

@BHoMBot check compliance
@BHoMBot check core
@BHoMBot check null-handling
@BHoMBot check serialisation

Copy link

bhombot-ci bot commented Feb 2, 2024

@pawelbaran to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check branch-compliance
  • check dataset-compliance
  • check copyright-compliance
  • check core
  • check null-handling
  • check serialisation

There are 3 requests in the queue ahead of you.

Copy link
Contributor

@albinber albinber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good and from the test file everything looks to be working as intended. Happy to approve

@FraserGreenroyd
Copy link
Contributor

@BHoMBot check versioning
@BHoMBot check installer

Copy link

bhombot-ci bot commented Feb 2, 2024

@FraserGreenroyd to confirm, the following actions are now queued:

  • check versioning
  • check installer

@FraserGreenroyd
Copy link
Contributor

@BHoMBot this is a DevOps instruction. I am requesting neutral checks on: unit-tests

Copy link

bhombot-ci bot commented Feb 2, 2024

@FraserGreenroyd I have provided neutral checks to the checks requested. These checks will need to be run properly to obtain full results.

@FraserGreenroyd
Copy link
Contributor

@BHoMBot check ready-to-merge

Copy link

bhombot-ci bot commented Feb 2, 2024

@FraserGreenroyd to confirm, the following actions are now queued:

  • check ready-to-merge

@FraserGreenroyd FraserGreenroyd merged commit a3b2796 into develop Feb 2, 2024
13 checks passed
@FraserGreenroyd FraserGreenroyd deleted the BHoM_Engine-#3273-ShiftListBug branch February 2, 2024 11:18
@bhombot-ci bhombot-ci bot mentioned this pull request Mar 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:bug Error or unexpected behaviour
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BHoM_Engine: ShiftList works only for numbers within range of the collection
3 participants