Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Geometry_Engine: UTs refreshed and Boolean operations bugfixed #3319

Merged
merged 10 commits into from
Mar 13, 2024

Conversation

pawelbaran
Copy link
Member

@pawelbaran pawelbaran commented Mar 12, 2024

Issues addressed by this PR

Closes #3277
Closes #3318
Closes #3320

Test files

All tests serialised in this PR are scripted in GH and uploaded here

Changelog

Additional comments

UTs cover the following PRs from 7.1:
#3275
#3280
#3283
#3290
#3292
#3293
#3298

@pawelbaran pawelbaran added the type:test-script Creation of unit test required label Mar 12, 2024
@pawelbaran pawelbaran self-assigned this Mar 12, 2024
@pawelbaran pawelbaran changed the title BHoM_Engine: UTs refreshed Geometry_Engine: UTs refreshed Mar 12, 2024
@pawelbaran pawelbaran changed the title Geometry_Engine: UTs refreshed Geometry_Engine: UTs refreshed and BooleanDifference bugfixed Mar 12, 2024
Copy link
Member

@peterjamesnugent peterjamesnugent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy that none of the unit tests (existing and newly added) are failing using FilterByCheckStatus.

Happy that the bug for colinear lines are fixed for BooleanDifference and modification of inputs is fixed for BooleanDifference and BooleanIntersection.

I did notice in the description the use of underscores, could remove that in a seperate PR or this one:

[Description("Returns the parts of the first line that are _not_ overlapping with the reference line, i.e. removes that parts of the first line that _is_ overlapping with the reference line. If the lines are not colinear or within tolerance distance of each other the full first line is returned.")]

@pawelbaran pawelbaran changed the title Geometry_Engine: UTs refreshed and BooleanDifference bugfixed Geometry_Engine: UTs refreshed and Boolean operations bugfixed Mar 13, 2024
@pawelbaran
Copy link
Member Author

Thanks @peterjamesnugent - I tweaked the descriptions now as the bot checks have not been run yet 👍

Copy link
Member

@peterjamesnugent peterjamesnugent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only changes to the descriptions, functionality not affected (and therefore previous review still valid).

@pawelbaran
Copy link
Member Author

@BHoMBot check required

Copy link

bhombot-ci bot commented Mar 13, 2024

@pawelbaran to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check core
  • check null-handling
  • check serialisation
  • check versioning
  • check installer

There are 53 requests in the queue ahead of you.

@FraserGreenroyd
Copy link
Contributor

@BHoMBot this is a DevOps instruction. I am requesting neutral checks on: unit-tests

Copy link

bhombot-ci bot commented Mar 13, 2024

@FraserGreenroyd I have provided neutral checks to the checks requested. These checks will need to be run properly to obtain full results.

@pawelbaran
Copy link
Member Author

@BHoMBot check dataset-compliance
@BHoMBot check copyright-compliance
@BHoMBot check ready-to-merge

Copy link

bhombot-ci bot commented Mar 13, 2024

@pawelbaran to confirm, the following actions are now queued:

  • check dataset-compliance
  • check copyright-compliance
  • check ready-to-merge

There are 3 requests in the queue ahead of you.

@FraserGreenroyd
Copy link
Contributor

@BHoMBot this is a DevOps instruction. I am requesting neutral checks on: dataset-compliance

Copy link

bhombot-ci bot commented Mar 13, 2024

@FraserGreenroyd I have provided neutral checks to the checks requested. These checks will need to be run properly to obtain full results.

@FraserGreenroyd FraserGreenroyd merged commit b5d2101 into develop Mar 13, 2024
12 checks passed
@FraserGreenroyd FraserGreenroyd deleted the BHoM_Engine-#3277-GeometryUTs branch March 13, 2024 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:test-script Creation of unit test required
Projects
None yet
3 participants