-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Geometry_Engine: UTs refreshed and Boolean operations bugfixed #3319
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Happy that none of the unit tests (existing and newly added) are failing using FilterByCheckStatus
.
Happy that the bug for colinear lines are fixed for BooleanDifference
and modification of inputs is fixed for BooleanDifference
and BooleanIntersection
.
I did notice in the description the use of underscores, could remove that in a seperate PR or this one:
[Description("Returns the parts of the first line that are _not_ overlapping with the reference line, i.e. removes that parts of the first line that _is_ overlapping with the reference line. If the lines are not colinear or within tolerance distance of each other the full first line is returned.")] |
Thanks @peterjamesnugent - I tweaked the descriptions now as the bot checks have not been run yet 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only changes to the descriptions, functionality not affected (and therefore previous review still valid).
@BHoMBot check required |
@pawelbaran to confirm, the following actions are now queued:
There are 53 requests in the queue ahead of you. |
@BHoMBot this is a DevOps instruction. I am requesting neutral checks on: unit-tests |
@FraserGreenroyd I have provided neutral checks to the checks requested. These checks will need to be run properly to obtain full results. |
@pawelbaran to confirm, the following actions are now queued:
There are 3 requests in the queue ahead of you. |
@BHoMBot this is a DevOps instruction. I am requesting neutral checks on: dataset-compliance |
@FraserGreenroyd I have provided neutral checks to the checks requested. These checks will need to be run properly to obtain full results. |
Issues addressed by this PR
Closes #3277
Closes #3318
Closes #3320
Test files
All tests serialised in this PR are scripted in GH and uploaded here
Changelog
Additional comments
UTs cover the following PRs from 7.1:
#3275
#3280
#3283
#3290
#3292
#3293
#3298