Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SearchMenu crashes the hosting UI if a method is defined in the global namespace #144

Merged
merged 2 commits into from
Oct 17, 2019
Merged

SearchMenu crashes the hosting UI if a method is defined in the global namespace #144

merged 2 commits into from
Oct 17, 2019

Conversation

epignatelli
Copy link
Member

@epignatelli epignatelli commented Oct 11, 2019 •
edited
Loading

Issues addressed by this PR

Closes #143

Test files

You can use the procedure described in #143 to test the issue inside and outside this pr.

Changelog

  • Fix crash happening when methods lie in the global namespace.
  • Methods in the global namespace have now assigned the Global category.

@epignatelli epignatelli added severity:critical No workaround exists. Essential to continue type:bug Error or unexpected behaviour labels Oct 11, 2019
@epignatelli epignatelli added this to the BHoM 3.0 β RC milestone Oct 11, 2019
@epignatelli epignatelli requested review from alelom and adecler October 11, 2019 10:53
@epignatelli epignatelli self-assigned this Oct 11, 2019
@epignatelli epignatelli mentioned this pull request Oct 11, 2019
Merged
alelom
alelom approved these changes Oct 16, 2019
View reviewed changes
Copy link
Member

@alelom alelom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, works, LGTM!

@adecler adecler merged commit 955dfb1 into master Oct 17, 2019
@adecler adecler deleted the BHoM_UI#143-NullNamespaceCrashesMenu branch October 17, 2019 03:34
This was referenced Dec 19, 2019
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alelom alelom alelom approved these changes

@adecler adecler Awaiting requested review from adecler

Assignees

@epignatelli epignatelli

Labels
severity:critical No workaround exists. Essential to continue type:bug Error or unexpected behaviour
Projects
None yet
Milestone
BHoM 3.0 β RC
Development

Successfully merging this pull request may close these issues.

SearchMenu crashes the hosting UI if a method has null namespace
3 participants
@epignatelli @alelom @adecler