Remove the ability to create typed objects from the CreateCustom component

[adecler]

Issues addressed by this PR

Closes #159

Test files

Just make sure that the CreateCustom component is not allowing you to select a type from its menu and that it is still working for creating custom objects

Additional comments

Make sure to also check the PR in Excel_Toolkit as some changes were needed there to keep it compiling

[epignatelli]

Thanks @adecler !

The BHoM_UI works ok by itself, but modifying the logic here breaks the CreateCustom behaviour in Grasshopper at least.

Selecting a different type from the parameter menu for a specific input does not work anymore. To test it:

1. Create a CreateCustom component
2. Add two inputs
3. Create a panel with the value true
4. Input the panel in both the inputs of the component
5. Change the TypeHint of the first input to int
6. If you use an Explode, you'll see that the change has no effects

I think the fix is just to check for type changes as well in grasshopper to decide when to recompute the solution.
Specifically, I think that these lines should add a check for the type:

            bool recompute = this.Phase == GH_SolutionPhase.Computed
                             && !e.Parameter.Sources.Any(p => p.Attributes.GetTopLevel.DocObject is ExplodeComponent)
                             && e.Parameter.NickName != Caller.InputParams[e.ParameterIndex].Name
                             && Engine.Grasshopper.Query.Type(e.Parameter) != Caller.InputParams[e.ParameterIndex].DataType;

[adecler]

@epignatelli , weird, it works perfectly fine for me:

Which makes sense because nothing in the code I have changed on this PR could trigger that effect. Are you sure you are on the correct version for all repos?

[epignatelli]

Yeah, that's very weird, but I agree with you, I was surprised in the first place.

What I don't actually understand is how it can be working now, without that check.
I'll re-check and make sure the branch set is correct!

[epignatelli]

I am not sure why it was not working before.
I checkout the latest masters, recompiled and now everything seems fine!

[epignatelli]

/azp BHoM_UI.CheckCore

[azure-pipelines]

Command 'BHoM_UI.CheckCore' is not supported by Azure Pipelines.

Supported commands

• help:
• Get descriptions, examples and documentation about supported commands
• Example: help "command_name"
• list:
• List all pipelines for this repository using a comment.
• Example: "list"
• run:
• Run all pipelines or a specific pipeline for this repository using a comment. Use this command by itself to trigger all related pipelines, or specify a pipeline to run.
• Example: "run" or "run pipeline_name"
• where:
• Report back the Azure DevOps orgs that are related to this repository and org
• Example: "where"

See additional documentation.

[epignatelli]

/azp run BHoM_UI.CheckCore

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[epignatelli]

/azp run BHoM_UI.CheckInstaller

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[epignatelli]

@adecler is there anything that prevents us from merging this?

[adecler]

@epignatelli , yes, Excel_Toolkit needs to be updated first as this PR was preventing it from compiling.

I did a quick attempt to fix it in https://github.com/BHoM/Excel_Toolkit/pull/170 but it was apparently a bit too quick 😋 . @awakeman is now on it to do that properly.

[epignatelli]

Ah, right, ok! I'll add a do-not-merge then, waiting for BHoM/Excel_Toolkit#170 to be closed.

Just wanted to prevent an accidental "Click the green button" automatism :D