You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After an attempt of solving this problem within the Versioning_Toolkit, I ended up taking care of it directly in the BHoM_UI. The main reason for it is the lack of return type stored in the json version of a MethodInfo. I tried to work with method Name and namespace to identify the return type but there was a few too many exceptions for my liking. Solving it here felt more robust and is after all a UI specific versioning issue. This doesn't change the fact that I will add a support for explicitly deprecated method in the versioning engine as planned.
Test files
Create some CreateObject components (make sure they use a specific Engine.Create method) and save the file.
Comment out the corresponding Create methods in the Engine and recompile
Reopened the saved script file and make sure the component is still working and now has the ability to remove inputs and an input selector menu.
Solving it here felt more robust and is after all a UI specific versioning issue. This doesn't change the fact that I will add a support for explicitly deprecated method in the versioning engine as planned.
Also - I don't know if you have already explicitly added UI deprecation as an additional use case to versioning going forward (in addition to the namespace, type, method, internal property cases etc.)
Will be good to add and summarise - there will always continue to be tweaks to the UI going forward which we will need to support backwards compatibility for.
However - agree there is significant difference between Versioning of oM and Engine, than rest of BHoM. With UI potentially requiring more responsibility for future changes in UI itself and Parent Adapter etc. Good to clarify all those potential cases and the lines between them.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
adecler
deleted the
BHoM_UI-#163-BackwardCompatibilityForEngineCreate
branch
Issues addressed by this PR
Closes #163
After an attempt of solving this problem within the Versioning_Toolkit, I ended up taking care of it directly in the BHoM_UI. The main reason for it is the lack of return type stored in the json version of a MethodInfo. I tried to work with method Name and namespace to identify the return type but there was a few too many exceptions for my liking. Solving it here felt more robust and is after all a UI specific versioning issue. This doesn't change the fact that I will add a support for explicitly deprecated method in the versioning engine as planned.
Test files
Additional comments
For the input selection menu to remove pre-existing inputs properly, make sure to use the corresponding PR in Grasshopper_Toolkit. For Dynamo, the equivalent fix has been pushed to the pending PR.