Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make sure that ComponentRequest has a location when menu is navigated via keyboard inputs #174

Merged
merged 3 commits into from
Dec 13, 2019
Merged

Make sure that ComponentRequest has a location when menu is navigated via keyboard inputs #174

merged 3 commits into from
Dec 13, 2019

Conversation

epignatelli
Copy link
Member

@epignatelli epignatelli commented Dec 12, 2019 •
edited
Loading

Issues addressed by this PR

This pr support the fixes implemented in BHoM/Grasshopper_UI#445 but does not depend on it.

Test files

You can test this pr in tandem with the associated Grasshopper_Toolkit one

Changelog

  • Make sure that when using the keyboard to navigate the BHoM menu, the component is not created at the mouse cursor location, but at the location of the top left corner of the menu

@epignatelli epignatelli self-assigned this Dec 12, 2019
@epignatelli epignatelli added the type:bug Error or unexpected behaviour label Dec 12, 2019
@epignatelli epignatelli added this to the BHoM 3.0 β RC milestone Dec 12, 2019
@epignatelli
Copy link
Member Author

Love the CheckCore ❤️ @FraserGreenroyd @al-fisher

@epignatelli epignatelli mentioned this pull request Dec 13, 2019
Merged
IsakNaslundBh
IsakNaslundBh approved these changes Dec 13, 2019
View reviewed changes
Copy link
Contributor

@IsakNaslundBh IsakNaslundBh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works well in GH and excel works fine as well form what I ahve tested

@epignatelli
Copy link
Member Author

/azp run BHoM_UI.CheckInstaller

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@epignatelli epignatelli merged commit 3329034 into master Dec 13, 2019
@adecler adecler deleted the Grasshopper_Toolkit#417-Explode branch December 17, 2019 07:19
This was referenced Dec 19, 2019
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IsakNaslundBh IsakNaslundBh IsakNaslundBh approved these changes

@adecler adecler Awaiting requested review from adecler

Assignees

@epignatelli epignatelli

Labels
type:bug Error or unexpected behaviour
Projects
None yet
Milestone
BHoM 3.0 β RC
Development

Successfully merging this pull request may close these issues.
2 participants
@epignatelli @IsakNaslundBh