Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Search in dropdowns unlocked #450

Merged
merged 1 commit into from
Feb 16, 2023
Merged

Search in dropdowns unlocked #450

merged 1 commit into from
Feb 16, 2023

Conversation

pawelbaran
Copy link
Member

NOTE: Depends on

Issues addressed by this PR

Closes #449

Test files

Try creating and navigating dropdowns (enums, datasets) - search bar should be available under right click now.

Changelog

Additional comments

@pawelbaran pawelbaran added the type:feature New capability or enhancement label Feb 15, 2023
@pawelbaran pawelbaran self-assigned this Feb 15, 2023
This was referenced Feb 15, 2023
Merged
Merged
adecler
adecler approved these changes Feb 16, 2023
View reviewed changes
Copy link
Member

@adecler adecler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works very well. Love that it applies to both the enum and database dropdowns.

@pawelbaran
Copy link
Member Author

@BHoMBot check core
@BHoMBot check compliance

1 similar comment
@pawelbaran
Copy link
Member Author

@BHoMBot check core
@BHoMBot check compliance

@bhombot-ci
Copy link

bhombot-ci bot commented Feb 16, 2023

@pawelbaran to confirm, the following actions are now queued:

  • check core
  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check branch-compliance
  • check dataset-compliance
  • check copyright-compliance

There are 1 requests in the queue ahead of you.

@pawelbaran
Copy link
Member Author

@BHoMBot check versioning
@BHoMBot check installer

@bhombot-ci
Copy link

bhombot-ci bot commented Feb 16, 2023

@pawelbaran to confirm, the following actions are now queued:

  • check versioning
  • check installer

@pawelbaran
Copy link
Member Author

@BHoMBot check ready-to-merge

@bhombot-ci
Copy link

bhombot-ci bot commented Feb 16, 2023

@pawelbaran to confirm, the following actions are now queued:

  • check ready-to-merge

There are 14 requests in the queue ahead of you.

@adecler adecler merged commit 3334ac9 into develop Feb 16, 2023
@adecler adecler deleted the BHoM_UI-#449-SearchInDropdowns branch February 16, 2023 12:34
@bhombot-ci bhombot-ci bot mentioned this pull request Mar 13, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adecler adecler adecler approved these changes

Assignees

@pawelbaran pawelbaran

Labels
type:feature New capability or enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add search in dropdowns
2 participants
@pawelbaran @adecler