Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

6.3 Deployment #119

Merged
merged 7 commits into from
Sep 21, 2023
Merged

6.3 Deployment #119

merged 7 commits into from
Sep 21, 2023

Conversation

bhombot-ci[bot]
Copy link

@bhombot-ci bhombot-ci bot commented Sep 11, 2023

BHoMBot and others added 7 commits September 11, 2023 12:17
-Create methods names must match type of item created
-per Fraser's suggestion, we are still using CarbonQueryDatabaseRequest for the method name, but created a subfolder named GetRequest inside Create
@albinber
Copy link

@BHoMBot check compliance

@bhombot-ci
Copy link
Author

bhombot-ci bot commented Sep 19, 2023

@albinber to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check branch-compliance
  • check dataset-compliance
  • check copyright-compliance

There are 236 requests in the queue ahead of you.

@bhombot-ci
Copy link
Author

bhombot-ci bot commented Sep 20, 2023

@bhombot-ci[bot] just to let you know, I have provided a check-installer result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @peterjamesnugent on ETABS_Toolkit

@bhombot-ci
Copy link
Author

bhombot-ci bot commented Sep 20, 2023

@bhombot-ci[bot] just to let you know, I have provided a check-installer result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @FraserGreenroyd on BHoM

Copy link
Contributor

@michaelhoehn michaelhoehn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved and tested against beta installers dated 230917, 230918, 230919

@FraserGreenroyd
Copy link

@BHoMBot check core
@BHoMBot check null-handling
@BHoMBot check serialisation

@bhombot-ci
Copy link
Author

bhombot-ci bot commented Sep 20, 2023

@FraserGreenroyd to confirm, the following actions are now queued:

  • check core
  • check null-handling
  • check serialisation

There are 126 requests in the queue ahead of you.

@bhombot-ci
Copy link
Author

bhombot-ci bot commented Sep 20, 2023

@bhombot-ci[bot] just to let you know, I have provided a check-versioning result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @FraserGreenroyd on Versioning_Toolkit

@FraserGreenroyd
Copy link

@BHoMBot check null-handling

@bhombot-ci
Copy link
Author

bhombot-ci bot commented Sep 21, 2023

@FraserGreenroyd to confirm, the following actions are now queued:

  • check null-handling

There are 27 requests in the queue ahead of you.

Copy link

@FraserGreenroyd FraserGreenroyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Checked by DevOps following Testing Sprint. Everything is satisfactory, DevOps clear to merge.

@FraserGreenroyd
Copy link

@BHoMBot this is a DevOps instruction. I am requesting neutral checks on: ready-to-merge

@bhombot-ci
Copy link
Author

bhombot-ci bot commented Sep 21, 2023

@FraserGreenroyd I have provided neutral checks to the checks requested. These checks will need to be run properly to obtain full results.

@FraserGreenroyd FraserGreenroyd merged commit 45a6f0d into main Sep 21, 2023
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:compliance Non-conforming to code guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants