Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update assembly file version to 5.3 #102

Merged
merged 1 commit into from
Jun 27, 2022
Merged

Conversation

BHoMBot
Copy link
Member

@BHoMBot BHoMBot commented Jun 27, 2022

Update assembly file version to 5.3

@FraserGreenroyd FraserGreenroyd added the type:compliance Non-conforming to code guidelines label Jun 27, 2022
@bhombot-ci
Copy link

bhombot-ci bot commented Jun 27, 2022

@BHoMBot just to let you know, I have provided a check-installer result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @FraserGreenroyd on BHoM

Copy link
Contributor

@FraserGreenroyd FraserGreenroyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving from a DevOps perspective after code review.

@FraserGreenroyd
Copy link
Contributor

@BHoMBot check required

@bhombot-ci
Copy link

bhombot-ci bot commented Jun 27, 2022

@FraserGreenroyd to confirm, the following checks are now queued:

  • code-compliance
  • documentation-compliance
  • project-compliance
  • core
  • null-handling
  • serialisation
  • versioning
  • installer

There are 465 requests in the queue ahead of you.

@bhombot-ci
Copy link

bhombot-ci bot commented Jun 27, 2022

@BHoMBot just to let you know, I have provided a check-installer result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @FraserGreenroyd on SQL_Toolkit

@FraserGreenroyd
Copy link
Contributor

@BHoMBot check copyright-compliance

@bhombot-ci
Copy link

bhombot-ci bot commented Jun 27, 2022

@FraserGreenroyd to confirm, the following checks are now queued:

  • copyright-compliance

There are 941 requests in the queue ahead of you.

@FraserGreenroyd
Copy link
Contributor

@BHoMBot check versioning

@bhombot-ci
Copy link

bhombot-ci bot commented Jun 27, 2022

@FraserGreenroyd to confirm, the following checks are now queued:

  • versioning

There are 1137 requests in the queue ahead of you.

@bhombot-ci
Copy link

bhombot-ci bot commented Jun 27, 2022

The check installer has already been run previously and recorded as a successful check. This check has not been run again at this time.

@bhombot-ci
Copy link

bhombot-ci bot commented Jun 27, 2022

@BHoMBot just to let you know, I have provided a check-installer result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @FraserGreenroyd on BHoMAnalytics_Toolkit

@FraserGreenroyd
Copy link
Contributor

@BHoMBot check versioningBHoMBot check ready-to-merge

@bhombot-ci
Copy link

bhombot-ci bot commented Jun 27, 2022

@FraserGreenroyd sorry, I didn't understand.
Was that comment an instruction for me? If so, could you state again what check you would like me to do?
For a list of available instructions, please see this wiki page.

@FraserGreenroyd FraserGreenroyd merged commit 0f504e3 into main Jun 27, 2022
@FraserGreenroyd FraserGreenroyd deleted the BHoM-UptickTo53 branch June 27, 2022 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:compliance Non-conforming to code guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants