Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove legacy code and compilation warnings #186

Merged
merged 4 commits into from
Nov 27, 2019

Conversation

adecler
Copy link
Member

@adecler adecler commented Nov 27, 2019

Issues addressed by this PR

Closes #180

Test files

  • Make sure code compiles without warnings
  • Try a few of your existing scripts to make sure everything is still working
  • Create a CustomObject component and copy/paste it to make sure serialisation works fine. You will require to have the BHoM on this pending PR for everything to work fine but this PR doesn't depend on it (Just want to make sure you don't report bugs that are already taken care of 😄 )

@adecler adecler added the type:compliance Non-conforming to code guidelines label Nov 27, 2019
@adecler adecler added this to the BHoM 3.0 β MVP milestone Nov 27, 2019
@adecler adecler self-assigned this Nov 27, 2019
Copy link
Contributor

@FraserGreenroyd FraserGreenroyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, managed to pull a model out of Revit on an existing script, copied/pasted a Create Custom Component, and code has no warnings 😄

@adecler adecler merged commit 6d3e7c3 into master Nov 27, 2019
@adecler adecler deleted the Dynamo_Toolkit-#180-CompilationWarnings branch November 27, 2019 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:compliance Non-conforming to code guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dynamo_Toolkit: Resolve compilation warnings
2 participants