Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Compliance - Inconsistent Namespaces and ErrorLog #216

Merged
merged 3 commits into from
Oct 25, 2019
Merged

Compliance - Inconsistent Namespaces and ErrorLog #216

merged 3 commits into from
Oct 25, 2019

Conversation

JosefTaylor
Copy link
Contributor

@JosefTaylor JosefTaylor commented Oct 4, 2019 •
edited by alelom
Loading

Issues addressed by this PR

Two compliance issues:

Closes #215
Closes #219

Capitalized all instances of ETABS, except those which are in PascalCase/camelCase, i.e. object names. Maybe we should hit those too?

Changelog

  • Capitalized Etabs namespaces where not all cap, so they are all ETABS; only exceptions are those things that want PascalCase/camelCase (i.e. object names)
  • Changed calls to the now superseded ErrorLog to use Reflection.RecordError
  • Removed GetNextIdOfType() which is no longer used because NextId() has been disabled.

@JosefTaylor JosefTaylor added this to the BHoM 3.0 β MVP milestone Oct 4, 2019
@JosefTaylor JosefTaylor self-assigned this Oct 4, 2019
@alelom alelom changed the title Issue215 Inconsistent Namespaces Compliance - Inconsistent Namespaces and ErrorLog Oct 14, 2019
@alelom alelom added type:compliance Non-conforming to code guidelines status:WIP PR in progress and still in draft, not ready for formal review size:S Measured in minutes labels Oct 14, 2019
@alelom alelom mentioned this pull request Oct 14, 2019
Closed
3 tasks
@alelom alelom mentioned this pull request Oct 25, 2019
Merged
3 tasks
@alelom alelom removed the status:WIP PR in progress and still in draft, not ready for formal review label Oct 25, 2019
alelom
alelom approved these changes Oct 25, 2019
View reviewed changes
Copy link
Member

@alelom alelom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works fine, LGTM!

@JosefTaylor JosefTaylor merged commit 67077a0 into master Oct 25, 2019
@JosefTaylor JosefTaylor deleted the ETABS_Toolkit-issue215-inconsistent-namespaces branch October 25, 2019 14:00
This was referenced Dec 19, 2019
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alelom alelom alelom approved these changes

@IsakNaslundBh IsakNaslundBh Awaiting requested review from IsakNaslundBh

Assignees

@JosefTaylor JosefTaylor

Labels
size:S Measured in minutes type:compliance Non-conforming to code guidelines
Projects
None yet
Milestone
BHoM 3.0 β MVP
2 participants
@JosefTaylor @alelom