Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Excel_Toolkit: Improved UX for adapter pull #38

Merged
merged 2 commits into from
Sep 6, 2023

Conversation

albinber
Copy link
Contributor

@albinber albinber commented Sep 6, 2023

NOTE: Depends on

Issues addressed by this PR

Closes #37

Test files

Changelog

Additional comments

@albinber albinber added the type:documentation Wiki, help or in code attributes label Sep 6, 2023
@albinber albinber self-assigned this Sep 6, 2023
@albinber
Copy link
Contributor Author

albinber commented Sep 6, 2023

@BHoMBot check compliance

@bhombot-ci
Copy link

bhombot-ci bot commented Sep 6, 2023

@albinber to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check branch-compliance
  • check dataset-compliance
  • check copyright-compliance

There are 22 requests in the queue ahead of you.

@FraserGreenroyd
Copy link

@BHoMBot check required

@bhombot-ci
Copy link

bhombot-ci bot commented Sep 6, 2023

@FraserGreenroyd to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check core
  • check null-handling
  • check serialisation
  • check versioning
  • check installer

There are 15 requests in the queue ahead of you.

@bhombot-ci
Copy link

bhombot-ci bot commented Sep 6, 2023

The check code-compliance has already been run previously and recorded as a successful check. This check has not been run again at this time.

@bhombot-ci
Copy link

bhombot-ci bot commented Sep 6, 2023

The check documentation-compliance has already been run previously and recorded as a successful check. This check has not been run again at this time.

Copy link

@FraserGreenroyd FraserGreenroyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

UX is improved with less options to confuse users with, great find @albinber

@FraserGreenroyd
Copy link

@BHoMBot check ready-to-merge

@bhombot-ci
Copy link

bhombot-ci bot commented Sep 6, 2023

@FraserGreenroyd to confirm, the following actions are now queued:

  • check ready-to-merge

There are 8 requests in the queue ahead of you.

@FraserGreenroyd FraserGreenroyd added type:user-experience Issues and changes relating to improving the overall User Experience (UX) of the tools and removed type:documentation Wiki, help or in code attributes labels Sep 6, 2023
@FraserGreenroyd FraserGreenroyd merged commit 33d9f2f into develop Sep 6, 2023
12 checks passed
@FraserGreenroyd FraserGreenroyd deleted the Excel_Toolkit-#37-ImprovingUX branch September 6, 2023 13:30
@bhombot-ci bhombot-ci bot mentioned this pull request Sep 11, 2023
@bhombot-ci bhombot-ci bot mentioned this pull request Dec 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:user-experience Issues and changes relating to improving the overall User Experience (UX) of the tools
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve UX for adapter pull
2 participants