Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update nuget package to match PowerPoint Toolkit #47

Merged
merged 1 commit into from
Nov 21, 2023

Conversation

FraserGreenroyd
Copy link

Issues addressed by this PR

Fixes BHoM/PowerPoint_Toolkit#8

Test files

Test both Excel Toolkit and PowerPoint Toolkit - this PowerPoint PR from @adecler has a decent test script for testing PowerPoint Toolkit.

Test pulling and pushing information to/from Excel and the test script for PowerPoint Toolkit.

Changelog

Additional comments

@FraserGreenroyd FraserGreenroyd added the type:bug Error or unexpected behaviour label Nov 21, 2023
@FraserGreenroyd FraserGreenroyd self-assigned this Nov 21, 2023
Copy link
Member

@adecler adecler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested both Excel adapter and PowerPoint adapter in the same Grasshopper instance and they are both working correctly after the fix from this PR.

Copy link
Contributor

@Tom-Kingstone Tom-Kingstone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested Powerpoint_Toolkit using the test script provided, and the output Powerpoint is as expected. Also tested Excel pulling and pushing, and was working as expected.

@FraserGreenroyd
Copy link
Author

@BHoMBot check compliance
@BHoMBot check core

Copy link

bhombot-ci bot commented Nov 21, 2023

@FraserGreenroyd to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check branch-compliance
  • check dataset-compliance
  • check copyright-compliance
  • check core

@FraserGreenroyd
Copy link
Author

@BHoMBot check installer
@BHoMBot check null-handling
@BHoMBot check serialisation

Copy link

bhombot-ci bot commented Nov 21, 2023

@FraserGreenroyd to confirm, the following actions are now queued:

  • check installer
  • check null-handling
  • check serialisation

@FraserGreenroyd
Copy link
Author

@BHoMBot check versioning

Copy link

bhombot-ci bot commented Nov 21, 2023

@FraserGreenroyd to confirm, the following actions are now queued:

  • check versioning

@FraserGreenroyd
Copy link
Author

@BHoMBot check ready-to-merge

Copy link

bhombot-ci bot commented Nov 21, 2023

@FraserGreenroyd to confirm, the following actions are now queued:

  • check ready-to-merge

@FraserGreenroyd FraserGreenroyd merged commit 4c5d22b into develop Nov 21, 2023
12 checks passed
@FraserGreenroyd FraserGreenroyd deleted the Excel_Toolkit-#42-UpdateNuspec branch November 21, 2023 15:19
@bhombot-ci bhombot-ci bot mentioned this pull request Dec 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:bug Error or unexpected behaviour
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DocumentFormat_OpenXML not compliant with PowerPoint_Toolkit
3 participants