-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update nuget package to match PowerPoint Toolkit #47
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested both Excel adapter and PowerPoint adapter in the same Grasshopper instance and they are both working correctly after the fix from this PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested Powerpoint_Toolkit using the test script provided, and the output Powerpoint is as expected. Also tested Excel pulling and pushing, and was working as expected.
@FraserGreenroyd to confirm, the following actions are now queued:
|
@FraserGreenroyd to confirm, the following actions are now queued:
|
@BHoMBot check versioning |
@FraserGreenroyd to confirm, the following actions are now queued:
|
@BHoMBot check ready-to-merge |
@FraserGreenroyd to confirm, the following actions are now queued:
|
Issues addressed by this PR
Fixes BHoM/PowerPoint_Toolkit#8
Test files
Test both Excel Toolkit and PowerPoint Toolkit - this PowerPoint PR from @adecler has a decent test script for testing PowerPoint Toolkit.
Test pulling and pushing information to/from Excel and the test script for PowerPoint Toolkit.
Changelog
Additional comments