Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Align with changes of the SelectorMenu class name #169

Merged
merged 1 commit into from
Nov 9, 2019
Merged

Align with changes of the SelectorMenu class name #169

merged 1 commit into from
Nov 9, 2019

Conversation

adecler
Copy link
Member

@adecler adecler commented Nov 9, 2019

NOTE: Depends on

BHoM/BHoM_UI#152

Test files

Just make sure it compiles with BHoM/BHoM_UI#152

@adecler adecler added the type:external-api-changes Imposed changes, including from dependency across other BHoM repos label Nov 9, 2019
@adecler adecler added this to the BHoM 3.0 β MVP milestone Nov 9, 2019
@adecler adecler self-assigned this Nov 9, 2019
@adecler adecler mentioned this pull request Nov 9, 2019
Merged
al-fisher
al-fisher approved these changes Nov 9, 2019
View reviewed changes
Copy link
Member

@al-fisher al-fisher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @adecler
Working now! Will approve - and merge the associated BHoM_UI etc.

@al-fisher al-fisher merged commit 6a570b9 into master Nov 9, 2019
@al-fisher al-fisher deleted the BHoM_UI-#151-RefineCreateObject branch November 9, 2019 13:15
This was referenced Dec 19, 2019
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@al-fisher al-fisher al-fisher approved these changes

@awakeman awakeman Awaiting requested review from awakeman

@epignatelli epignatelli Awaiting requested review from epignatelli

Assignees

@adecler adecler

Labels
type:external-api-changes Imposed changes, including from dependency across other BHoM repos
Projects
None yet
Milestone
BHoM 3.0 β MVP
Development

Successfully merging this pull request may close these issues.
2 participants
@adecler @al-fisher