Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the versioning issues following the split #350

Merged
merged 2 commits into from
Jul 5, 2022

Conversation

FraserGreenroyd
Copy link
Contributor

Providing versioning starts passing then this is good to go.

@FraserGreenroyd FraserGreenroyd added the type:compliance Non-conforming to code guidelines label Jul 5, 2022
@FraserGreenroyd FraserGreenroyd self-assigned this Jul 5, 2022
@FraserGreenroyd
Copy link
Contributor Author

@BHoMBot check versioning

@bhombot-ci
Copy link

bhombot-ci bot commented Jul 5, 2022

@FraserGreenroyd to confirm, the following checks are now queued:

  • versioning

There are 60 requests in the queue ahead of you.

@FraserGreenroyd FraserGreenroyd marked this pull request as ready for review July 5, 2022 11:48
@FraserGreenroyd
Copy link
Contributor Author

@BHoMBot check versioning

@bhombot-ci
Copy link

bhombot-ci bot commented Jul 5, 2022

@FraserGreenroyd to confirm, the following checks are now queued:

  • versioning

There are 1 requests in the queue ahead of you.

@FraserGreenroyd
Copy link
Contributor Author

@BHoMBot check required

@bhombot-ci
Copy link

bhombot-ci bot commented Jul 5, 2022

@FraserGreenroyd to confirm, the following checks are now queued:

  • code-compliance
  • documentation-compliance
  • project-compliance
  • core
  • null-handling
  • serialisation
  • versioning
  • installer

There are 1 requests in the queue ahead of you.

@bhombot-ci
Copy link

bhombot-ci bot commented Jul 5, 2022

The check versioning has already been run previously and recorded as a successful check. This check has not been run again at this time.

@FraserGreenroyd
Copy link
Contributor Author

@BHoMBot check copyright-compliance

@bhombot-ci
Copy link

bhombot-ci bot commented Jul 5, 2022

@FraserGreenroyd to confirm, the following checks are now queued:

  • copyright-compliance

Copy link
Member

@alelom alelom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving on the bases of code changes only. Focus on versioning so ok to separate out fixing documentation.

@FraserGreenroyd
Copy link
Contributor Author

@BHoMBot check ready-to-merge

@bhombot-ci
Copy link

bhombot-ci bot commented Jul 5, 2022

@FraserGreenroyd to confirm, the following checks are now queued:

  • ready-to-merge

@FraserGreenroyd FraserGreenroyd merged commit 380d8ad into main Jul 5, 2022
@FraserGreenroyd FraserGreenroyd deleted the ExcelUI-#347-FixVersioning branch July 5, 2022 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:compliance Non-conforming to code guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants