Fix Excel VBA not functioning #356
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@IsakNaslundBh to confirm, the following actions are now queued:
|
FraserGreenroyd
approved these changes
Sep 7, 2022
There was a problem hiding this comment.
Well now...
Code reviewed, added in the ComServer element which was removed in #342 . Happy to merge for further tests via alphas.
|
@BHoMBot check ready-to-merge |
1 similar comment
|
@BHoMBot check ready-to-merge |
|
@FraserGreenroyd to confirm, the following actions are now queued:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues addressed by this PR
Closes #355
When the DNA plugin was updated in #342 the
ComServer="true"was missed, which made the VBA not registering and functioning correctly.This remedies that issue.
Test files
https://burohappold.sharepoint.com/:f:/s/BHoM/Ep4DW3joYwtCqimPTsdNVAcBMXdE5YGr58gf5jpkirYElQ?e=XaVYcP
Changelog
Additional comments