Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert Persistent ProjectID Changes #372

Merged
merged 1 commit into from
Dec 13, 2022
Merged

Revert Persistent ProjectID Changes #372

merged 1 commit into from
Dec 13, 2022

Conversation

travispotterBH
Copy link

This reverts commit fb6df8a.

NOTE: Depends on

Issues addressed by this PR

Closes #371

Test files

Changelog

Additional comments

@travispotterBH travispotterBH added the type:bug Error or unexpected behaviour label Dec 13, 2022
@travispotterBH travispotterBH self-assigned this Dec 13, 2022
@FraserGreenroyd
Copy link
Contributor

@BHoMBot check versioning

@bhombot-ci
Copy link

bhombot-ci bot commented Dec 13, 2022

@FraserGreenroyd to confirm, the following actions are now queued:

  • check versioning

There are 2 requests in the queue ahead of you.

@FraserGreenroyd
Copy link
Contributor

@BHoMBot check installer

@bhombot-ci
Copy link

bhombot-ci bot commented Dec 13, 2022

@FraserGreenroyd to confirm, the following actions are now queued:

  • check installer

There are 2 requests in the queue ahead of you.

@FraserGreenroyd
Copy link
Contributor

FraserGreenroyd commented Dec 13, 2022 •
edited
Loading

@BHoMBot check core
@BHoMBot check null-handling
@BHoMBot check project-compliance
@BHoMBot check serialisation
@BHoMBot check copyright-compliance

@bhombot-ci
Copy link

bhombot-ci bot commented Dec 13, 2022

@FraserGreenroyd to confirm, the following actions are now queued:

  • check core
  • check null-handling
  • check project-compliance
  • check serialisation
  • check copyright-compliance

There are 9 requests in the queue ahead of you.

FraserGreenroyd
FraserGreenroyd approved these changes Dec 13, 2022
View reviewed changes
Copy link
Contributor

@FraserGreenroyd FraserGreenroyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reverts the commit as discussed.

@FraserGreenroyd
Copy link
Contributor

@BHoMBot check ready-to-merge

@bhombot-ci
Copy link

bhombot-ci bot commented Dec 13, 2022

@FraserGreenroyd to confirm, the following actions are now queued:

  • check ready-to-merge

@FraserGreenroyd FraserGreenroyd merged commit 7eb34d0 into main Dec 13, 2022
@FraserGreenroyd FraserGreenroyd deleted the Excel_UI-#371-RevertPersistentProjectIDChanges branch December 13, 2022 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FraserGreenroyd FraserGreenroyd FraserGreenroyd approved these changes

Assignees

@travispotterBH travispotterBH

Labels
type:bug Error or unexpected behaviour
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Revert Persistent ProjectID Changes
2 participants
@travispotterBH @FraserGreenroyd