Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Aligning with changes in BHoMAdapter Refactoring Level 04 #26

Merged
merged 4 commits into from
Jan 24, 2020

Conversation

awakeman
Copy link
Member

@awakeman awakeman commented Jan 10, 2020

@awakeman awakeman self-assigned this Jan 10, 2020
@awakeman awakeman added the type:compliance Non-conforming to code guidelines label Jan 10, 2020
@awakeman awakeman added this to the BHoM 3.1 β MVP milestone Jan 10, 2020
@al-fisher al-fisher added status:do-not-merge For instance, test PR, for discussion, or dependant PRs not ready for merge type:external-api-changes Imposed changes, including from dependency across other BHoM repos labels Jan 10, 2020
@awakeman
Copy link
Member Author

Copy link
Member

@alelom alelom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes LGTM.

Copy link

@JonathanNillius JonathanNillius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test files look good!

@al-fisher al-fisher removed the type:compliance Non-conforming to code guidelines label Jan 24, 2020
@FraserGreenroyd FraserGreenroyd removed the status:do-not-merge For instance, test PR, for discussion, or dependant PRs not ready for merge label Jan 24, 2020
@awakeman awakeman merged commit 22fd7f3 into master Jan 24, 2020
@awakeman awakeman deleted the BHoM_Adapter-refactoringLvl04-01 branch January 24, 2020 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:external-api-changes Imposed changes, including from dependency across other BHoM repos
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Filing_Toolkit: Align to changes for BHoM_Adapter refactoring level 04
5 participants