Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

No error messages for trying to create CAT sections #118

Merged
merged 1 commit into from
Oct 17, 2019
Merged

No error messages for trying to create CAT sections #118

merged 1 commit into from
Oct 17, 2019

Conversation

IsakNaslundBh
Copy link
Contributor

Issues addressed by this PR

Closes #117

  • Add optional boolean for if errors should be rasied from COMcall method, defaulting to true
  • Setting said boolean to false for generating CAT sections

Test files

https://burohappold.sharepoint.com/:f:/s/BHoM/EuY51LbYbL5ClkOuFjX7g6oBdhjCP_-ZlA4pEv3GQ3FD_w?e=erz2yv

Changelog

Additional comments

@IsakNaslundBh
Fixes #117
0504c26 
-Add optional boolean for if errors should be rasied from COMcall method, defaulting to true
- Setting said boolean to false for generating CAT sections
@IsakNaslundBh IsakNaslundBh added the type:bug Error or unexpected behaviour label Oct 17, 2019
@IsakNaslundBh IsakNaslundBh added this to the BHoM 3.0 β MVP milestone Oct 17, 2019
@IsakNaslundBh IsakNaslundBh self-assigned this Oct 17, 2019
alelom
alelom approved these changes Oct 17, 2019
View reviewed changes
Copy link
Member

@alelom alelom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, works, LGTM.
image

@IsakNaslundBh
Copy link
Contributor Author

Thanks!

@IsakNaslundBh IsakNaslundBh merged commit dfaeb5a into master Oct 17, 2019
@IsakNaslundBh IsakNaslundBh deleted the GSA_Toolkit-#117-NoErrorMessageForCatSections branch October 17, 2019 13:01
This was referenced Dec 19, 2019
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alelom alelom alelom approved these changes

@al-fisher al-fisher Awaiting requested review from al-fisher

Assignees

@IsakNaslundBh IsakNaslundBh

Labels
type:bug Error or unexpected behaviour
Projects
None yet
Milestone
BHoM 3.0 β MVP
Development

Successfully merging this pull request may close these issues.

GSA_Toolkit: Avoid showing error messages when failing to create CAT sections
2 participants
@IsakNaslundBh @alelom