Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for check for empty request leading to Default Request #128

Merged

Conversation

IsakNaslundBh
Copy link
Contributor

@IsakNaslundBh IsakNaslundBh commented Nov 14, 2019

Issues addressed by this PR

Closes #127

Fixing Pull override will always enter default if type is not filterRequest

@IsakNaslundBh IsakNaslundBh added the type:bug Error or unexpected behaviour label Nov 14, 2019
@IsakNaslundBh IsakNaslundBh added this to the BHoM 3.0 β MVP milestone Nov 14, 2019
@IsakNaslundBh IsakNaslundBh self-assigned this Nov 14, 2019
Copy link
Member

@alelom alelom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@IsakNaslundBh IsakNaslundBh merged commit caea78f into master Nov 14, 2019
@IsakNaslundBh IsakNaslundBh deleted the GSA_Toolkit-#127-BugDefaultIsCalledForAllRequests branch November 14, 2019 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:bug Error or unexpected behaviour
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GSA_Toolkit: Pull override exception will always enter default if type is not filterRequest
2 participants