Aligning with changes in BHoMAdapter Refactoring Level 04 #75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FraserGreenroyd
added
status:do-not-merge
FraserGreenroyd
requested review from
alelom,
BingWangUS,
tg359,
vbeardow,
MajaLindroth and
RasmusCanfjorden
alelom
requested changes
Jan 17, 2020
alelom
approved these changes
Jan 22, 2020
There was a problem hiding this comment.
Approved on the basis of the new changes I put in.
This needs testing. As discussed, no testing can be done from my side on this.
Please test this thoroughly and leave a request for changes in case you believe these changes made this not work under any script of yours.
RasmusCanfjorden
approved these changes
Jan 23, 2020
MajaLindroth
approved these changes
Jan 23, 2020
FraserGreenroyd
removed
the
status:do-not-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE: Depends on
BHoM/BHoM_Engine#1371
BHoM/BHoM_Adapter#164
BHoM/BHoM_UI#167
If you use Grasshopper: Aligning with changes in BHoMAdapter Refactoring Level 04 Grasshopper_UI#440
If you use Excel: https://github.com/BHoM/Excel_Toolkit/pull/172
If you use Dynamo: Aligning with changes in BHoMAdapter Refactoring Level 04 Dynamo_UI#188
If your Toolkit needs Socket_Toolkit: Aligning with changes in BHoMAdapter Refactoring Level 04 Socket_Toolkit#57
If your Toolkit needs Mongo_Toolkit: Aligning with changes in BHoMAdapter Refactoring Level 04 Mongo_Toolkit#82
If you want the Adapter components to be automatically upgraded to their new version in your test scripts: Adding support for method upgrade Versioning_Toolkit#8
Issues addressed by this PR
Fixes #72
Test files
Existing scripts