Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates to simulations, external comfort, and plots #106

Merged
merged 11 commits into from
Aug 7, 2023

Conversation

jamesramsden-bh
Copy link
Contributor

@jamesramsden-bh jamesramsden-bh commented Jul 25, 2023

Includes some refactoring off the back of several projects within the python src folder. Test against the usual test batch file within the Python folder.

Closes #98
Closes #100
Closes #104

@jamesramsden-bh jamesramsden-bh changed the title Interim fixes Updates to simulations, external comfort, and plots Jul 25, 2023
@jamesramsden-bh
Copy link
Contributor Author

@BHoMBot check required

@bhombot-ci
Copy link

bhombot-ci bot commented Jul 26, 2023

@jamesramsden-bh to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check core
  • check null-handling
  • check serialisation
  • check versioning
  • check installer

There are 171 requests in the queue ahead of you.

@FraserGreenroyd
Copy link
Contributor

@BHoMBot check copyright-compliance
@BHoMBot check dataset-compliance
@BHoMBot check unit-tests

@bhombot-ci
Copy link

bhombot-ci bot commented Jul 31, 2023

@FraserGreenroyd to confirm, the following actions are now queued:

  • check copyright-compliance
  • check dataset-compliance
  • check unit-tests

@FraserGreenroyd FraserGreenroyd added the type:feature New capability or enhancement label Aug 1, 2023
@jamesramsden-bh
Copy link
Contributor Author

@BHoMBot check required

@bhombot-ci
Copy link

bhombot-ci bot commented Aug 7, 2023

@jamesramsden-bh to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check core
  • check null-handling
  • check serialisation
  • check versioning
  • check installer

Copy link
Contributor

@FraserGreenroyd FraserGreenroyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have run through the code with @jamesramsden-bh on a call and all is in line with his testing of work done in collaboration with @tg359 - happy to approve to deploy to unblock them.

@jamesramsden-bh
Copy link
Contributor Author

@BHoMBot check copyright-compliance
@BHoMBot check dataset-compliance
@BHoMBot check unit-tests
@BHoMBot check ready-to-merge

@bhombot-ci
Copy link

bhombot-ci bot commented Aug 7, 2023

@jamesramsden-bh to confirm, the following actions are now queued:

  • check copyright-compliance
  • check dataset-compliance
  • check unit-tests
  • check ready-to-merge

@jamesramsden-bh jamesramsden-bh merged commit 78bc969 into develop Aug 7, 2023
12 checks passed
@jamesramsden-bh jamesramsden-bh deleted the interim-fixes branch August 7, 2023 11:22
@bhombot-ci bhombot-ci bot mentioned this pull request Sep 11, 2023
@bhombot-ci bhombot-ci bot mentioned this pull request Dec 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:feature New capability or enhancement
Projects
None yet
3 participants