-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Python virtual environment creation fixes and refactor #107
Python virtual environment creation fixes and refactor #107
Conversation
2007535
to
8d88272
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reinstalled with corresponding PR for Python TK. Installs successfully. Unit tests and a manual spot check all tested and no problems.
@BHoMBot check required |
@jamesramsden-bh to confirm, the following actions are now queued:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reconfirming approval after accidentally re-requesting a review from myself...
@BHoMBot check required |
@jamesramsden-bh to confirm, the following actions are now queued:
There are 15 requests in the queue ahead of you. |
The check |
The check |
The check |
@jamesramsden-bh to confirm, the following actions are now queued:
There are 37 requests in the queue ahead of you. |
The check |
The check |
The check |
The check |
@BHoMBot this is a DevOps instruction. I am requesting neutral checks on: versioning, ready-to-merge |
@FraserGreenroyd I have provided neutral checks to the checks requested. These checks will need to be run properly to obtain full results. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My changes have been addressed, happy to merge.
NOTE: Depends on
BHoM/Python_Toolkit#107
Issues addressed by this PR
Test files
Changelog
Additional comments