Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python virtual environment creation fixes and refactor #107

Merged
merged 3 commits into from
Aug 9, 2023

Conversation

tg359
Copy link
Contributor

@tg359 tg359 commented Aug 3, 2023

NOTE: Depends on

BHoM/Python_Toolkit#107

Issues addressed by this PR

Test files

Changelog

Additional comments

@tg359 tg359 added the status:WIP PR in progress and still in draft, not ready for formal review label Aug 3, 2023
@tg359 tg359 self-assigned this Aug 3, 2023
@FraserGreenroyd FraserGreenroyd force-pushed the Python_Toolkit-#106-EnvironmentsOverhaul branch from 2007535 to 8d88272 Compare August 7, 2023 14:29
@jamesramsden-bh jamesramsden-bh self-requested a review August 8, 2023 13:31
Copy link
Contributor

@jamesramsden-bh jamesramsden-bh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reinstalled with corresponding PR for Python TK. Installs successfully. Unit tests and a manual spot check all tested and no problems.

@jamesramsden-bh
Copy link
Contributor

@BHoMBot check required

@bhombot-ci
Copy link

bhombot-ci bot commented Aug 8, 2023

@jamesramsden-bh to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check core
  • check null-handling
  • check serialisation
  • check versioning
  • check installer

@jamesramsden-bh jamesramsden-bh added the type:feature New capability or enhancement label Aug 8, 2023
@jamesramsden-bh jamesramsden-bh changed the title Python toolkit #106 environments overhaul Python virtual environment creation fixes and refactor Aug 9, 2023
@jamesramsden-bh jamesramsden-bh self-requested a review August 9, 2023 10:07
Copy link
Contributor

@jamesramsden-bh jamesramsden-bh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reconfirming approval after accidentally re-requesting a review from myself...

@jamesramsden-bh
Copy link
Contributor

@BHoMBot check required

@bhombot-ci
Copy link

bhombot-ci bot commented Aug 9, 2023

@jamesramsden-bh to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check core
  • check null-handling
  • check serialisation
  • check versioning
  • check installer

There are 15 requests in the queue ahead of you.

@bhombot-ci
Copy link

bhombot-ci bot commented Aug 9, 2023

The check code-compliance has already been run previously and recorded as a successful check. This check has not been run again at this time.

@bhombot-ci
Copy link

bhombot-ci bot commented Aug 9, 2023

The check documentation-compliance has already been run previously and recorded as a successful check. This check has not been run again at this time.

@bhombot-ci
Copy link

bhombot-ci bot commented Aug 9, 2023

The check project-compliance has already been run previously and recorded as a successful check. This check has not been run again at this time.

@jamesramsden-bh
Copy link
Contributor

@BHoMBot check copyright-compliance
@BHoMBot check dataset-compliance
@BHoMBot check unit-tests

@bhombot-ci
Copy link

bhombot-ci bot commented Aug 9, 2023

@jamesramsden-bh to confirm, the following actions are now queued:

  • check copyright-compliance
  • check dataset-compliance
  • check unit-tests

There are 37 requests in the queue ahead of you.

@bhombot-ci
Copy link

bhombot-ci bot commented Aug 9, 2023

The check core has already been run previously and recorded as a successful check. This check has not been run again at this time.

@bhombot-ci
Copy link

bhombot-ci bot commented Aug 9, 2023

The check null-handling has already been run previously and recorded as a successful check. This check has not been run again at this time.

@bhombot-ci
Copy link

bhombot-ci bot commented Aug 9, 2023

The check serialisation has already been run previously and recorded as a successful check. This check has not been run again at this time.

@bhombot-ci
Copy link

bhombot-ci bot commented Aug 9, 2023

The check installer has already been run previously and recorded as a successful check. This check has not been run again at this time.

@FraserGreenroyd
Copy link
Contributor

@BHoMBot this is a DevOps instruction. I am requesting neutral checks on: versioning, ready-to-merge

@bhombot-ci
Copy link

bhombot-ci bot commented Aug 9, 2023

@FraserGreenroyd I have provided neutral checks to the checks requested. These checks will need to be run properly to obtain full results.

Copy link
Contributor

@FraserGreenroyd FraserGreenroyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My changes have been addressed, happy to merge.

@FraserGreenroyd FraserGreenroyd merged commit 0ee4ad9 into develop Aug 9, 2023
12 checks passed
@FraserGreenroyd FraserGreenroyd deleted the Python_Toolkit-#106-EnvironmentsOverhaul branch August 9, 2023 11:48
@bhombot-ci bhombot-ci bot mentioned this pull request Sep 11, 2023
@bhombot-ci bhombot-ci bot mentioned this pull request Dec 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status:WIP PR in progress and still in draft, not ready for formal review type:feature New capability or enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants