-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cast radiation_porosity and wind_porosity to list(float) #203
Cast radiation_porosity and wind_porosity to list(float) #203
Conversation
@BHoMBot check required |
@Tom-Kingstone to confirm, the following actions are now queued:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested with a typology of mixed ints and floats, external comfort now calculates without raising an error.
@BHoMBot check required |
@jamesramsden-bh to confirm, the following actions are now queued:
There are 2 requests in the queue ahead of you. |
The check |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested and the issue no longer appears, thanks @Tom-Kingstone.
@Tom-Kingstone to confirm, the following actions are now queued:
|
@BHoMBot check ready-to-merge |
@Tom-Kingstone to confirm, the following actions are now queued:
|
NOTE: Depends on
Issues addressed by this PR
Closes #200
If the type check for list(float, int) passes, now casts radiation and wind porosity to list(float).
Test files
Changelog
Additional comments