Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pluralise descriptions for Duration Converts #101

Conversation

peterjamesnugent
Copy link
Member

@peterjamesnugent peterjamesnugent commented Nov 20, 2023

NOTE: Depends on

Issues addressed by this PR

Closes #100

Test files

By inspection

Changelog

Additional comments

@peterjamesnugent
Copy link
Member Author

@BHoMBot check required
@BHoMBot check copyright-compliance

Copy link

bhombot-ci bot commented Nov 20, 2023

@peterjamesnugent to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check core
  • check null-handling
  • check serialisation
  • check versioning
  • check installer
  • check copyright-compliance

There are 55 requests in the queue ahead of you.

Copy link
Contributor

@FraserGreenroyd FraserGreenroyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In line with the issue and as discussed on Teams, happy to merge.

@FraserGreenroyd
Copy link
Contributor

@BHoMBot this is a DevOps instruction. I am requesting neutral checks on: code-compliance, copyright-compliance, dataset-compliance, documentation-compliance, installer, null-handling, project-compliance, ready-to-merge, serialisation, versioning

@FraserGreenroyd
Copy link
Contributor

@BHoMBot check core

Copy link

bhombot-ci bot commented Nov 20, 2023

@FraserGreenroyd to confirm, the following actions are now queued:

  • check core

There are 53 requests in the queue ahead of you.

Copy link

bhombot-ci bot commented Nov 20, 2023

@FraserGreenroyd I have provided neutral checks to the checks requested. These checks will need to be run properly to obtain full results.

@FraserGreenroyd FraserGreenroyd merged commit d99d943 into develop Nov 20, 2023
11 checks passed
@FraserGreenroyd FraserGreenroyd deleted the Localisation_Toolkit-#100-PluralsUsedInDurationDescriptions branch November 20, 2023 17:41
@bhombot-ci bhombot-ci bot mentioned this pull request Dec 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:compliance Non-conforming to code guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Plurals used in Duration methods
2 participants