Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pulling a MeshSettings1D with a divisions parameters results in a casting error (when the divisions = 1) #404

Closed
peterjamesnugent opened this issue Mar 28, 2024 · 1 comment · Fixed by #406
Closed

Pulling a MeshSettings1D with a divisions parameters results in a casting error (when the divisions = 1) #404

peterjamesnugent opened this issue Mar 28, 2024 · 1 comment · Fixed by #406
Assignees
@peterjamesnugent
Labels
type:bug Error or unexpected behaviour
Milestone
BHoM 7.2 β MVP

Comments

@peterjamesnugent
Copy link
Member

peterjamesnugent commented Mar 28, 2024 •
edited
Loading

Description:

Pulling a MeshSettings1D that is split by divisions results in an error.

Steps to reproduce:

See test script and file.

Expected behaviour:

Successfully able to Pull MeshSettings1D where divisions = 1.

Test file(s):
@peterjamesnugent peterjamesnugent added the type:bug Error or unexpected behaviour label Mar 28, 2024
@peterjamesnugent peterjamesnugent added this to the BHoM 7.2 β MVP milestone Mar 28, 2024
@peterjamesnugent peterjamesnugent self-assigned this Mar 28, 2024
@peterjamesnugent peterjamesnugent changed the title Pulling a MeshSettings1D with a divisions parameters results in a casting error Pulling a MeshSettings1D with a divisions parameters results in a casting error (when the divisions = 1) Mar 28, 2024
@peterjamesnugent
Copy link
Member Author

object[] ratios = lusasMeshLine.getMeshDivisions(0); will fix it here:

Lusas_Toolkit/Lusas_Adapter/Convert/ToBHoM/Properties/ToMeshSettings1D.cs

Line 62 in 91f5cdd

object[] ratios = lusasMeshLine.getValue("ratio");

@peterjamesnugent peterjamesnugent mentioned this issue Apr 3, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@peterjamesnugent peterjamesnugent

Labels
type:bug Error or unexpected behaviour
Projects
None yet
Milestone
BHoM 7.2 β MVP
Development

Successfully merging a pull request may close this issue.

Fixes bug whereby pulling a MeshSettings1D with div = 1 returns an error BHoM/Lusas_Toolkit
1 participant
@peterjamesnugent