-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes bug whereby pulling a MeshSettings1D with div = 1 returns an error #406
Fixes bug whereby pulling a MeshSettings1D with div = 1 returns an error #406
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested for Lusas v.20.0 and v21.0 using the testscript provided. Works as expected and no error occurs when pulling a MeshSettings1D
with divisions = 1.
Happy to approve for Lusas v.20.0 and v.21.0.
@BHoMBot check compliance |
@FraserGreenroyd to confirm, the following actions are now queued:
|
@BHoMBot check required |
@peterjamesnugent to confirm, the following actions are now queued:
There are 29 requests in the queue ahead of you. |
The check |
The check |
@BHoMBot check installer |
@peterjamesnugent to confirm, the following actions are now queued:
|
@BHoMBot check ready-to-merge |
@peterjamesnugent to confirm, the following actions are now queued:
|
Issues addressed by this PR
Closes #404
Test files
https://burohappold.sharepoint.com/:u:/r/sites/BHoM/02_Current/12_Scripts/01_Issue/BHoM/Lusas_Toolkit/%23404%20Pull%20MeshSettings1D/PullMeshSettings1D.gh?csf=1&web=1&e=zU6eQp
Changelog
Additional comments