Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes bug whereby pulling a MeshSettings1D with div = 1 returns an error #406

Merged

Conversation

peterjamesnugent
Copy link
Member

@peterjamesnugent peterjamesnugent added the type:bug Error or unexpected behaviour label Apr 3, 2024
@peterjamesnugent peterjamesnugent added this to the BHoM 7.2 β MVP milestone Apr 3, 2024
@peterjamesnugent peterjamesnugent self-assigned this Apr 3, 2024
@KalleEdstroem KalleEdstroem self-requested a review April 3, 2024 08:55
Copy link
Contributor

@KalleEdstroem KalleEdstroem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested for Lusas v.20.0 and v21.0 using the testscript provided. Works as expected and no error occurs when pulling a MeshSettings1D with divisions = 1.
Happy to approve for Lusas v.20.0 and v.21.0.

@FraserGreenroyd
Copy link
Contributor

@BHoMBot check compliance

Copy link

bhombot-ci bot commented Apr 3, 2024

@FraserGreenroyd to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check branch-compliance
  • check dataset-compliance
  • check copyright-compliance

@peterjamesnugent peterjamesnugent added the status:do-not-merge For instance, test PR, for discussion, or dependant PRs not ready for merge label Apr 3, 2024
@peterjamesnugent
Copy link
Member Author

@BHoMBot check required

Copy link

bhombot-ci bot commented May 29, 2024

@peterjamesnugent to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check core
  • check null-handling
  • check serialisation
  • check versioning
  • check installer

There are 29 requests in the queue ahead of you.

@peterjamesnugent peterjamesnugent removed the status:do-not-merge For instance, test PR, for discussion, or dependant PRs not ready for merge label May 29, 2024
Copy link

bhombot-ci bot commented May 29, 2024

The check code-compliance has already been run previously and recorded as a successful check. This check has not been run again at this time.

Copy link

bhombot-ci bot commented May 29, 2024

The check documentation-compliance has already been run previously and recorded as a successful check. This check has not been run again at this time.

@peterjamesnugent
Copy link
Member Author

@BHoMBot check installer

Copy link

bhombot-ci bot commented May 30, 2024

@peterjamesnugent to confirm, the following actions are now queued:

  • check installer

@peterjamesnugent
Copy link
Member Author

@BHoMBot check ready-to-merge

Copy link

bhombot-ci bot commented May 30, 2024

@peterjamesnugent to confirm, the following actions are now queued:

  • check ready-to-merge

@peterjamesnugent peterjamesnugent merged commit 811097d into develop May 30, 2024
12 checks passed
@peterjamesnugent peterjamesnugent deleted the Lusas_Toolkit-#404-MeshSettings1DBugWithOneDivision branch May 30, 2024 15:00
@bhombot-ci bhombot-ci bot mentioned this pull request Jun 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:bug Error or unexpected behaviour
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pulling a MeshSettings1D with a divisions parameters results in a casting error (when the divisions = 1)
3 participants