Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update AssemblyVersion and AssemblyFileVersion to 3.0.0.0 #192

Merged
merged 1 commit into from
Oct 28, 2019
Merged

Update AssemblyVersion and AssemblyFileVersion to 3.0.0.0 #192

merged 1 commit into from
Oct 28, 2019

Conversation

peterjamesnugent
Copy link
Member

Issues addressed by this PR

Closes #191

Test

Make sure that:

  • All the .csproj files in the solution have the properties AssemblyFileVersion to 3.0.0.0 and AssemblyVersion to 3.0.0.0.
  • The AssemblyCopyright reads [assembly: AssemblyCopyright("Copyright © https://github.com/BHoM")]

Changelog

  • Update AssemblyFileVersion to 3.0.0.0
  • Update AssemblyVersion to 3.0.0.0

@peterjamesnugent peterjamesnugent added severity:low Doesn't stop/slow current workflow size:XS Measured in seconds type:compliance Non-conforming to code guidelines labels Oct 28, 2019
@peterjamesnugent peterjamesnugent added this to the BHoM 3.0 β RC milestone Oct 28, 2019
@peterjamesnugent peterjamesnugent self-assigned this Oct 28, 2019
alelom
alelom approved these changes Oct 28, 2019
View reviewed changes
Copy link
Member

@alelom alelom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@peterjamesnugent peterjamesnugent merged commit 22b539e into master Oct 28, 2019
@peterjamesnugent peterjamesnugent deleted the Issue-191-Update-AssemblyVersion-and-AssemblyFileVersion-to-3.0.0.0 branch October 28, 2019 15:50
This was referenced Dec 19, 2019
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alelom alelom alelom approved these changes

Assignees

@peterjamesnugent peterjamesnugent

Labels
severity:low Doesn't stop/slow current workflow size:XS Measured in seconds type:compliance Non-conforming to code guidelines
Projects
None yet
Milestone
BHoM 3.0 β RC
Development

Successfully merging this pull request may close these issues.

Update AssemblyVersion and AssemblyFileVersion to 3.0.0.0
2 participants
@peterjamesnugent @alelom