Fix bug where PointDisplacement is incorrectly assigned #193
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peterjamesnugent
added
severity:medium
ismaelibrahim
approved these changes
Nov 12, 2019
This was referenced Dec 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues addressed by this PR
Closes #190
PointDisplacementloads were being incorrectly applied to nodes.Test files
https://burohappold.sharepoint.com/:f:/s/BHoM/EhfSrsAvM4FBqQqRC-7GizQBu7sDKLd1Vxn5mirBB08sHg?e=SlAoUq
Changelog
https://burohappold.sharepoint.com/:f:/s/BHoM/EhfSrsAvM4FBqQqRC-7GizQBu7sDKLd1Vxn5mirBB08sHg?e=SlAoUq
Additional comments
The
PointIDof a LusasPoint (Node) is not synonmous with theLusas_id, as the PointID cannot be set. Therefore, the Lusas_Toolkit uses the name parameter of theLusasPointto mirror theAdapterId.So when you push a
Nodeto Lusas, you can force the Lusas_id to be 2 (as I have done in the script) but thePointIDwill not be unrelated. The name of theLusasPointwill be "P2" to reflect the Lusas_id.This was the source of the error, the
PointDisplacementassignment was using theLusas_idbut not adding the prefix, resulting in the load being incorrectly assigned.