Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Aligning with changes in BHoM_Adapter #199

Merged
merged 2 commits into from
Nov 1, 2019
Merged

Aligning with changes in BHoM_Adapter #199

merged 2 commits into from
Nov 1, 2019

Conversation

peterjamesnugent
Copy link
Member

NOTE: Depends on

BHoM/BHoM_Adapter#151

Issues addressed by this PR

Closes #197

Updating adapter to align with changes in the parent BHoM_Adapter

Test files

To test, make sure to switch to the relevant branches:

@peterjamesnugent peterjamesnugent added severity:critical No workaround exists. Essential to continue size:M Measured in hours type:external-api-changes Imposed changes, including from dependency across other BHoM repos labels Nov 1, 2019
@peterjamesnugent peterjamesnugent added this to the BHoM 3.0 β MVP milestone Nov 1, 2019
@peterjamesnugent peterjamesnugent self-assigned this Nov 1, 2019
FraserGreenroyd
FraserGreenroyd approved these changes Nov 1, 2019
View reviewed changes
Copy link
Contributor

@FraserGreenroyd FraserGreenroyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@peterjamesnugent peterjamesnugent merged commit 2b0508b into master Nov 1, 2019
@peterjamesnugent peterjamesnugent deleted the BHoM_Adapter-refactoringLvl3-01 branch November 1, 2019 14:57
@peterjamesnugent peterjamesnugent mentioned this pull request Nov 1, 2019
Closed
This was referenced Dec 19, 2019
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FraserGreenroyd FraserGreenroyd FraserGreenroyd approved these changes

@alelom alelom Awaiting requested review from alelom

@ismaelibrahim ismaelibrahim Awaiting requested review from ismaelibrahim

Assignees

@peterjamesnugent peterjamesnugent

Labels
severity:critical No workaround exists. Essential to continue size:M Measured in hours type:external-api-changes Imposed changes, including from dependency across other BHoM repos
Projects
None yet
Milestone
BHoM 3.0 β MVP
Development

Successfully merging this pull request may close these issues.

Adapting to changes in BHoMAdapter
2 participants
@peterjamesnugent @FraserGreenroyd