Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix altConfigs #361

Merged
merged 1 commit into from
Jul 31, 2023
Merged

Fix altConfigs #361

merged 1 commit into from
Jul 31, 2023

Conversation

FraserGreenroyd
Copy link
Contributor

Fixes #360

@FraserGreenroyd FraserGreenroyd added the type:compliance Non-conforming to code guidelines label Jul 31, 2023
@FraserGreenroyd FraserGreenroyd self-assigned this Jul 31, 2023
peterjamesnugent
peterjamesnugent approved these changes Jul 31, 2023
View reviewed changes
Copy link
Member

@peterjamesnugent peterjamesnugent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved by inspection.

vietle-bh
vietle-bh approved these changes Jul 31, 2023
View reviewed changes
Copy link

@vietle-bh vietle-bh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First time I'm in this toolkit 😅 but the changes make sense.

@FraserGreenroyd
Copy link
Contributor Author

@BHoMBot check compliance
@BHoMBot check required

@bhombot-ci
Copy link

bhombot-ci bot commented Jul 31, 2023

@FraserGreenroyd to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check branch-compliance
  • check dataset-compliance
  • check copyright-compliance
  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check core
  • check null-handling
  • check serialisation
  • check versioning
  • check installer

There are 137 requests in the queue ahead of you.

@FraserGreenroyd
Copy link
Contributor Author

@BHoMBot this is a DevOps instruction. I am requesting neutral checks on: installer, ready-to-merge

@bhombot-ci
Copy link

bhombot-ci bot commented Jul 31, 2023

@FraserGreenroyd I have provided neutral checks to the checks requested. These checks will need to be run properly to obtain full results.

@FraserGreenroyd FraserGreenroyd merged commit 931ad33 into develop Jul 31, 2023
12 checks passed
@FraserGreenroyd FraserGreenroyd deleted the Lusas_Toolkit-#360-AltConfigs branch July 31, 2023 16:40
@bhombot-ci bhombot-ci bot mentioned this pull request Sep 11, 2023
Merged
@bhombot-ci bhombot-ci bot mentioned this pull request Dec 11, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vietle-bh vietle-bh vietle-bh approved these changes

@peterjamesnugent peterjamesnugent peterjamesnugent approved these changes

@travispotterBH travispotterBH Awaiting requested review from travispotterBH

Assignees

@FraserGreenroyd FraserGreenroyd

Labels
type:compliance Non-conforming to code guidelines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix altConfigs file
3 participants
@FraserGreenroyd @peterjamesnugent @vietle-bh