Fix bug for BarRelease that did not pull correctly #366
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@BHoMBot check required |
|
@peterjamesnugent to confirm, the following actions are now queued:
|
|
@BHoMBot check copyright-compliance |
|
@peterjamesnugent to confirm, the following actions are now queued:
There are 9 requests in the queue ahead of you. |
KalleEdstroem
approved these changes
Sep 13, 2023
|
@BHoMBot check ready-to-merge |
|
@peterjamesnugent to confirm, the following actions are now queued:
|
peterjamesnugent
deleted the
Lusas_Tooklkit-#365-FixBugForBarReleases
branch
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues addressed by this PR
Closes #365
No changes to the functionality for Lusas191 and prior - just wrapped up the
BarReleasein a pre-processor directive and renamed a method.Test files
https://burohappold.sharepoint.com/:u:/r/sites/BHoM/02_Current/12_Scripts/01_Issue/BHoM/Lusas_Toolkit/%23365%20BarRelease%20not%20reading.gh?csf=1&web=1&e=7a17UE
Changelog
BarReleasecould not be pulled from Lusas v20.0 due to a failed LPI call;Additional comments