Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug for pulling results and update warning message #369

Merged

Conversation

peterjamesnugent
Copy link
Member

@peterjamesnugent peterjamesnugent commented Sep 14, 2023

Issues addressed by this PR

Closes #285

Test files

https://burohappold.sharepoint.com/:u:/s/BHoM/ESo_WOJCO0JPhMzd9EQr6PwBzgelLv1pb2NWXvIwQcg_KQ?e=BaB2gm

Changelog

  • Fixed bug where BarResults and MeshResults were unable to pull when CaseIds were not provided due to a change from int to long
  • Updated warning message when pulling MeshStress that incorrectly referred to Axial strain

Additional comments

@StephennipBH the original issue related to Lusas 19 but I suspect they fixed the problem in a minor version update.

@peterjamesnugent peterjamesnugent added the type:bug Error or unexpected behaviour label Sep 14, 2023
@peterjamesnugent peterjamesnugent self-assigned this Sep 14, 2023
Copy link
Contributor

@KalleEdstroem KalleEdstroem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Script worked as intended.
Warning message was updated.
Meshresults and barresults were pulled

@peterjamesnugent
Copy link
Member Author

@BHoMBot check required
@BHoMBot check copyright-compliance
@BHoMBot check ready-to-merge

@bhombot-ci
Copy link

bhombot-ci bot commented Sep 14, 2023

@peterjamesnugent to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check core
  • check null-handling
  • check serialisation
  • check versioning
  • check installer
  • check copyright-compliance
  • check ready-to-merge

There are 2 requests in the queue ahead of you.

@peterjamesnugent
Copy link
Member Author

@BHoMBot check versioning
@BHoMBot check installer

@bhombot-ci
Copy link

bhombot-ci bot commented Sep 14, 2023

@peterjamesnugent to confirm, the following actions are now queued:

  • check versioning
  • check installer

There are 1 requests in the queue ahead of you.

@bhombot-ci
Copy link

bhombot-ci bot commented Sep 14, 2023

The check installer has already been run previously and recorded as a successful check. This check has not been run again at this time.

@peterjamesnugent
Copy link
Member Author

@BHoMBot check ready-to-merge

@bhombot-ci
Copy link

bhombot-ci bot commented Sep 15, 2023

@peterjamesnugent to confirm, the following actions are now queued:

  • check ready-to-merge

Copy link
Contributor

@StephennipBH StephennipBH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes work as intended, Changes approved.

@peterjamesnugent peterjamesnugent merged commit 6239443 into develop Sep 15, 2023
10 checks passed
@peterjamesnugent peterjamesnugent deleted the Lusas_Toolkit-#285-FixBugForPullingResults branch September 15, 2023 09:24
@bhombot-ci bhombot-ci bot mentioned this pull request Dec 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:bug Error or unexpected behaviour
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Node Reaction and Mesh Stress results returned as 0 error
3 participants