Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Psychrometrics_Toolkit: Unit Compliance #55

Merged
merged 25 commits into from
Sep 6, 2023

Conversation

albinber
Copy link
Contributor

@albinber albinber commented Sep 4, 2023

NOTE: Depends on

Issues addressed by this PR

Closes #39

Test files

Changelog

Additional comments

@albinber albinber added the type:compliance Non-conforming to code guidelines label Sep 4, 2023
@albinber
Copy link
Contributor Author

albinber commented Sep 4, 2023

@BHoMBot check compliance
@BHoMBot check call

@bhombot-ci
Copy link

bhombot-ci bot commented Sep 4, 2023

@albinber to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check branch-compliance
  • check dataset-compliance
  • check copyright-compliance

Copy link

@FraserGreenroyd FraserGreenroyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use the typeof(Temperature) quantity attributes available from BH.oM.Quantity available here, rather than putting the units in brackets in the input descriptions 😄

Copy link

@FraserGreenroyd FraserGreenroyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also add BHoM/Localisation_Toolkit as a dependency in the dependencies.txt file 😄

Copy link

@FraserGreenroyd FraserGreenroyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See initial comments - spaces after the , on attribute inputs across the board please - I did the first file then realised it's a pattern so putting back on @albinber and @Tom-Kingstone to resolve please 😄

Psychrometrics_Engine/Compute/DensityWater.cs Outdated Show resolved Hide resolved
Psychrometrics_Engine/Compute/FromHumidityRatio.cs Outdated Show resolved Hide resolved
Psychrometrics_Engine/Compute/FromHumidityRatio.cs Outdated Show resolved Hide resolved
Psychrometrics_Engine/Compute/FromHumidityRatio.cs Outdated Show resolved Hide resolved
Psychrometrics_Engine/Compute/FromHumidityRatio.cs Outdated Show resolved Hide resolved
Psychrometrics_Engine/Compute/FromHumidityRatio.cs Outdated Show resolved Hide resolved
Psychrometrics_Engine/Compute/FromHumidityRatio.cs Outdated Show resolved Hide resolved
Psychrometrics_Engine/Compute/FromHumidityRatio.cs Outdated Show resolved Hide resolved
Psychrometrics_Engine/Compute/FromHumidityRatio.cs Outdated Show resolved Hide resolved
@FraserGreenroyd
Copy link

@BHoMBot check compliance

@bhombot-ci
Copy link

bhombot-ci bot commented Sep 5, 2023

@FraserGreenroyd to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check branch-compliance
  • check dataset-compliance
  • check copyright-compliance

There are 65 requests in the queue ahead of you.

@FraserGreenroyd
Copy link

@BHoMBot check core
@BHoMBot check null-handling

@bhombot-ci
Copy link

bhombot-ci bot commented Sep 5, 2023

@FraserGreenroyd to confirm, the following actions are now queued:

  • check core
  • check null-handling

There are 44 requests in the queue ahead of you.

@FraserGreenroyd
Copy link

@BHoMBot check core
@BHoMBot check serialisation
@BHoMBot check versioning
@BHoMBot check installer

@bhombot-ci
Copy link

bhombot-ci bot commented Sep 5, 2023

@FraserGreenroyd to confirm, the following actions are now queued:

  • check core
  • check serialisation
  • check versioning
  • check installer

There are 12 requests in the queue ahead of you.

dependencies.txt Outdated Show resolved Hide resolved
@FraserGreenroyd
Copy link

@BHoMBot check core

@bhombot-ci
Copy link

bhombot-ci bot commented Sep 6, 2023

@FraserGreenroyd to confirm, the following actions are now queued:

  • check core

@FraserGreenroyd
Copy link

@BHoMBot check core

@bhombot-ci
Copy link

bhombot-ci bot commented Sep 6, 2023

@FraserGreenroyd to confirm, the following actions are now queued:

  • check core

dependencies.txt Outdated Show resolved Hide resolved
@FraserGreenroyd
Copy link

@BHoMBot check core

@bhombot-ci
Copy link

bhombot-ci bot commented Sep 6, 2023

@FraserGreenroyd to confirm, the following actions are now queued:

  • check core

@FraserGreenroyd
Copy link

@BHoMBot check versioning

@bhombot-ci
Copy link

bhombot-ci bot commented Sep 6, 2023

@FraserGreenroyd to confirm, the following actions are now queued:

  • check versioning

There are 1 requests in the queue ahead of you.

@FraserGreenroyd
Copy link

@BHoMBot check compliance

@bhombot-ci
Copy link

bhombot-ci bot commented Sep 6, 2023

@FraserGreenroyd to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check branch-compliance
  • check dataset-compliance
  • check copyright-compliance

There are 2 requests in the queue ahead of you.

Tom-Kingstone and others added 20 commits September 6, 2023 17:05
Co-authored-by: Fraser Greenroyd <fraser.greenroyd@burohappold.com>
Co-authored-by: Fraser Greenroyd <fraser.greenroyd@burohappold.com>
Co-authored-by: Fraser Greenroyd <fraser.greenroyd@burohappold.com>
Co-authored-by: Fraser Greenroyd <fraser.greenroyd@burohappold.com>
Co-authored-by: Fraser Greenroyd <fraser.greenroyd@burohappold.com>
Co-authored-by: Fraser Greenroyd <fraser.greenroyd@burohappold.com>
Co-authored-by: Fraser Greenroyd <fraser.greenroyd@burohappold.com>
Co-authored-by: Fraser Greenroyd <fraser.greenroyd@burohappold.com>
@FraserGreenroyd FraserGreenroyd force-pushed the Psychrometrics_Toolkit-#39-UnitCompliance branch from 7d26a70 to 9ce8b6d Compare September 6, 2023 16:06
@FraserGreenroyd
Copy link

@BHoMBot this is a DevOps instruction. I am requesting neutral checks on: core, installer, null-handling, serialisation, versioning, ready-to-merge

@bhombot-ci
Copy link

bhombot-ci bot commented Sep 6, 2023

@FraserGreenroyd I have provided neutral checks to the checks requested. These checks will need to be run properly to obtain full results.

@FraserGreenroyd
Copy link

@BHoMBot check compliance

@bhombot-ci
Copy link

bhombot-ci bot commented Sep 6, 2023

@FraserGreenroyd to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check branch-compliance
  • check dataset-compliance
  • check copyright-compliance

There are 6 requests in the queue ahead of you.

Copy link

@FraserGreenroyd FraserGreenroyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still all good following rebase

@FraserGreenroyd FraserGreenroyd merged commit b295bc6 into develop Sep 6, 2023
12 checks passed
@FraserGreenroyd FraserGreenroyd deleted the Psychrometrics_Toolkit-#39-UnitCompliance branch September 6, 2023 16:08
@bhombot-ci bhombot-ci bot mentioned this pull request Sep 11, 2023
@bhombot-ci bhombot-ci bot mentioned this pull request Dec 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:compliance Non-conforming to code guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Toolkit is not unit compliant
3 participants