Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unit tests updated #60

Merged
merged 2 commits into from
Sep 8, 2023
Merged

Unit tests updated #60

merged 2 commits into from
Sep 8, 2023

Conversation

Tom-Kingstone
Copy link
Contributor

Issues addressed by this PR

Closes #59

unit tests for specified methods updated (used to be Celsius based, now Kelvin based).

Additional comments

@Tom-Kingstone Tom-Kingstone added this to the BHoM 6.3 β MVP milestone Sep 8, 2023
@Tom-Kingstone Tom-Kingstone self-assigned this Sep 8, 2023
@Tom-Kingstone
Copy link
Contributor Author

@BHoMBot check required

@bhombot-ci
Copy link

bhombot-ci bot commented Sep 8, 2023

@Tom-Kingstone to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check core
  • check null-handling
  • check serialisation
  • check versioning
  • check installer

@FraserGreenroyd
Copy link

@BHoMBot check unit-tests

@bhombot-ci
Copy link

bhombot-ci bot commented Sep 8, 2023

@FraserGreenroyd to confirm, the following actions are now queued:

  • check unit-tests

There are 4 requests in the queue ahead of you.

@FraserGreenroyd
Copy link

@BHoMBot check copyright-compliance

@bhombot-ci
Copy link

bhombot-ci bot commented Sep 8, 2023

@FraserGreenroyd to confirm, the following actions are now queued:

  • check copyright-compliance

There are 37 requests in the queue ahead of you.

FraserGreenroyd
FraserGreenroyd approved these changes Sep 8, 2023
View reviewed changes
Copy link

@FraserGreenroyd FraserGreenroyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unit tests are passing, update is good, great work @Tom-Kingstone

@FraserGreenroyd FraserGreenroyd changed the title Psychrometrics toolkit unit tests updated Unit tests updated Sep 8, 2023
@FraserGreenroyd
Copy link

@BHoMBot check ready-to-merge

@bhombot-ci
Copy link

bhombot-ci bot commented Sep 8, 2023

@FraserGreenroyd to confirm, the following actions are now queued:

  • check ready-to-merge

There are 40 requests in the queue ahead of you.

@FraserGreenroyd FraserGreenroyd added the type:test-script Creation of unit test required label Sep 8, 2023
@FraserGreenroyd FraserGreenroyd merged commit 559fff6 into develop Sep 8, 2023
11 checks passed
@FraserGreenroyd FraserGreenroyd deleted the Psychrometrics_Toolkit-UnitTests branch September 8, 2023 08:51
@bhombot-ci bhombot-ci bot mentioned this pull request Sep 11, 2023
Merged
@bhombot-ci bhombot-ci bot mentioned this pull request Dec 11, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FraserGreenroyd FraserGreenroyd FraserGreenroyd approved these changes

Assignees

@Tom-Kingstone Tom-Kingstone

Labels
type:test-script Creation of unit test required
Projects
None yet
Milestone
BHoM 6.3 β MVP
Development

Successfully merging this pull request may close these issues.

An error occurred on a unit test
2 participants
@Tom-Kingstone @FraserGreenroyd