Add floor and wall openings both working, issue templates added #111
Conversation
Handl deck property creation through create method checking if name exists in ram already or needs to be created.
Floor creation appears to be working with openings, slab edges, and deck assigns. :O
Need to add functionality per EH's DataAccess feedback for deflection API data.
wall openings can only be added to lateral walls
enarhi
added
severity:medium
|
New test file added to: https://burohappold.sharepoint.com/:f:/r/sites/BHoM/02_Current/12_Scripts/01_Test%20Scripts/RAM_Toolkit/Issue77%20Floor%20and%20Wall%20Openings?csf=1&e=CUepQs 191208... Please check with that one, I am getting all openings coming through on my end as below:
|
|
For overlapping edges on openings on the floors the openings are eliminated as below: However, the opening comes through, its just a matter of how RAM handles it. Suggest this be moved to a separate issue as it is a unique case that should be avoided anyhow. Looks like the rest of the openings create options are working, if you can confirm on your end @JosefTaylor then we can go ahead and get this merged up. |
enarhi
changed the title
|
Looks good to me. I also tried multiple random openings. Maybe as a separate issue we can get a good error message about openings which are collinear with external edges. |
Issues addressed by this PR
Closes #77
Closes #108
Add wall openings now supported, add slab and opening also supported.
Changelog
Additional notes
Test script: https://burohappold.sharepoint.com/:f:/r/sites/BHoM/02_Current/12_Scripts/01_Test%20Scripts/RAM_Toolkit/Issue77%20Floor%20and%20Wall%20Openings?csf=1&e=CkcfEq