Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added UniformLoadSets and RAM Constructor #98

Merged
merged 11 commits into from
Oct 30, 2019
Merged

Added UniformLoadSets and RAM Constructor #98

merged 11 commits into from
Oct 30, 2019

Conversation

JosefTaylor
Copy link
Contributor

Closes #91

@JosefTaylor JosefTaylor added this to the BHoM 3.0 β MVP milestone Oct 15, 2019
@JosefTaylor
Copy link
Contributor Author

JosefTaylor commented Oct 15, 2019 •
edited
Loading

Should UniformLoadSet be:

  • dictionary<loadcase, double>
  • list and list
  • list<tuple<loadcase, double>>
  • list<dictionary<string, object>? where the keys are "loadcase" and "value"
  • dictionary<string, loadcase> and dictionary<string, double> where string is a unique name?

Should we allow more than one load per loadcase? Yes!

Josef Taylor and others added 9 commits October 15, 2019 16:32
added create method for uniformloadsets
f4ffa45 
It's not working yet.
Also changed RAM Engine and oM namespaces to conform to standards
Fixed create UniformLoadSet conditional
e3f3c60 
only Live load key exists in the dictionary: test for key inclusion rather than value.
Added Create(ContourLoad)
97ddb61 
Not done- see comments in method.
Added GetStory(Point)
d803412
changed some inconsequential claptrap
2e72df9
Added ContourLoadSet, fixed up some of the issues in Create(ContourLo…
8970072 
…adSet)
@enarhi
No duplicate sets, scoord to point working
3a4eb1f 
IPoints still causing issues with database, IPoint coords not updating
@enarhi
Area Load Create working
9d269bf 
Fixed z tol, IPoints handling. Still need to check multiple use cases for database unavailable bug.
@enarhi
Read Area Loads added
2a708b8
@enarhi enarhi marked this pull request as ready for review October 30, 2019 21:23
@enarhi
Copy link
Member

enarhi commented Oct 30, 2019 •
edited
Loading

Summary of current status for additional PR after BHoM Adapter change implementation:

Read area loads functioning.
Create area loads functioning.
Database freeze error needs further testing and possibly requires a fix.

Will not close #91 until this has undergone further testing in a couple days.

@JosefTaylor test files can be found at:
Test Scripts

Please confirm functionality on your end and we can merge.

@enarhi enarhi self-requested a review October 30, 2019 21:25
@JosefTaylor
Copy link
Contributor Author

I approve this message!

@enarhi enarhi merged commit 91fc098 into master Oct 30, 2019
@enarhi enarhi deleted the RAM_Toolkit-Issue91-Area-Loads branch October 30, 2019 22:08
This was referenced Dec 19, 2019
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@enarhi enarhi enarhi approved these changes

Assignees

@enarhi enarhi

@JosefTaylor JosefTaylor

Labels
None yet
Projects
None yet
Milestone
BHoM 3.0 β MVP
Development

Successfully merging this pull request may close these issues.

RAM_Toolkit: Create functionality for area loads
2 participants
@JosefTaylor @enarhi