Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revit_Toolkit: Move methods not referencing Revit API to BH.Engine.Adapters.Revit #457

Closed
3 of 4 tasks
pawelbaran opened this issue Nov 18, 2019 · 2 comments · Fixed by #469
Closed
3 of 4 tasks

Revit_Toolkit: Move methods not referencing Revit API to BH.Engine.Adapters.Revit #457

pawelbaran opened this issue Nov 18, 2019 · 2 comments · Fixed by #469
Assignees
@FraserGreenroyd @pawelbaran
Labels
type:compliance Non-conforming to code guidelines
Milestone
BHoM 3.0 β MVP

Comments

@pawelbaran
Copy link
Member

pawelbaran commented Nov 18, 2019 •
edited
Loading

Description:

Some methods that do not reference Revit API sit in BH.UI.Revit.Engine - they could be moved to BH.Engine.Adapters.Revit:
@pawelbaran pawelbaran added the type:compliance Non-conforming to code guidelines label Nov 18, 2019
@pawelbaran pawelbaran added this to the BHoM 3.0 β MVP milestone Nov 18, 2019
@FraserGreenroyd
Copy link
Contributor

Should they have Adapters in the namespace at all? I can't remember what the decision was on that?

@pawelbaran
Copy link
Member Author

I do not think we made an agreement on that. Personally I have no opinion: as long as everything works, the name can be anything.

@pawelbaran pawelbaran mentioned this issue Nov 22, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@FraserGreenroyd FraserGreenroyd

@pawelbaran pawelbaran

Labels
type:compliance Non-conforming to code guidelines
Projects
None yet
Milestone
BHoM 3.0 β MVP
Development

Successfully merging a pull request may close this issue.

Query.Discipline Cleaned Up BHoM/Revit_Toolkit
2 participants
@FraserGreenroyd @pawelbaran