Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Query.Discipline Cleaned Up #469

Merged
merged 1 commit into from
Nov 22, 2019
Merged

Query.Discipline Cleaned Up #469

merged 1 commit into from
Nov 22, 2019

Conversation

pawelbaran
Copy link
Member

Issues addressed by this PR

Closes #457
Closes #468

Changes as in the changelog + I made an (hopefully successful) attempt to simplify the code.

Test files

  • whole issue - file with suffix master will work correctly on both master and PR branch, while the one with suffix PR will work only on master (some stuff got exposed to the UI)
  • extracted infinite loop bug

Changelog

  • BH.UI.Revit.Engine.Query.Discipline methods have been deprecated and moved to BH.Engine.Adapters.Revit.Query
  • return type of Query.Discipline methods originally sitting in BH.Engine.Adapters.Revit.Query has been changed from a nullable to non-nullable enum (Discipline.Undefined is returned instead of null now)

@pawelbaran pawelbaran self-assigned this Nov 22, 2019
FraserGreenroyd
FraserGreenroyd approved these changes Nov 22, 2019
View reviewed changes
Copy link
Contributor

@FraserGreenroyd FraserGreenroyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

MajaLindroth
MajaLindroth approved these changes Nov 22, 2019
View reviewed changes
Copy link

@MajaLindroth MajaLindroth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test script works fine. Also tested to pull a Revit model while on the branch and that worked as well :)

@pawelbaran pawelbaran merged commit 64d1b86 into master Nov 22, 2019
@pawelbaran pawelbaran deleted the Revit_Toolkit-Issue457-DisciplineQueryCleanup branch November 22, 2019 16:37
This was referenced Dec 19, 2019
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FraserGreenroyd FraserGreenroyd FraserGreenroyd approved these changes

@MajaLindroth MajaLindroth MajaLindroth approved these changes

@al-fisher al-fisher Awaiting requested review from al-fisher al-fisher is a code owner

@rwemay rwemay Awaiting requested review from rwemay rwemay is a code owner

Assignees

@pawelbaran pawelbaran

Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@pawelbaran @FraserGreenroyd @MajaLindroth