Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RevitIdentifiers fragment refactored #1063

Merged
merged 5 commits into from
Aug 4, 2021
Merged

RevitIdentifiers fragment refactored #1063

merged 5 commits into from
Aug 4, 2021

Conversation

pawelbaran
Copy link
Member

@pawelbaran pawelbaran commented Aug 3, 2021 •
edited
Loading

NOTE: Depends on

BHoM/BHoM#1267
BHoM/Versioning_Toolkit#173

Issues addressed by this PR

Closes #884

Test files

On SharePoint.

Changelog

Additional comments

@pawelbaran pawelbaran added type:compliance Non-conforming to code guidelines type:feature New capability or enhancement labels Aug 3, 2021
@pawelbaran pawelbaran requested a review from alelom August 3, 2021 19:58
@pawelbaran pawelbaran self-assigned this Aug 3, 2021
@pawelbaran
Copy link
Member Author

@BHoMBot check compliance

@bhombot-ci
Copy link

bhombot-ci bot commented Aug 3, 2021

@pawelbaran to confirm, the following checks are now queued:

  • code-compliance
  • documentation-compliance
  • project-compliance
  • branch-compliance
  • dataset-compliance
  • copyright-compliance

@pawelbaran
Copy link
Member Author

@BHoMBot check versioning

@bhombot-ci
Copy link

bhombot-ci bot commented Aug 3, 2021

@pawelbaran to confirm, the following checks are now queued:

  • versioning

@pawelbaran pawelbaran force-pushed the BHoM-#1266-PersistentIdGetOnly branch from 70385ae to 47dc2c3 Compare August 3, 2021 20:08
@pawelbaran
Copy link
Member Author

@BHoMBot check required

@bhombot-ci
Copy link

bhombot-ci bot commented Aug 3, 2021

@pawelbaran to confirm, the following checks are now queued:

  • code-compliance
  • documentation-compliance
  • project-compliance
  • core
  • null-handling
  • serialisation
  • installer
  • versioning

There are 12 requests in the queue ahead of you.

@pawelbaran
Copy link
Member Author

@BHoMBot check copyright-compliance
@BHoMBot check dataset-compliance

@bhombot-ci
Copy link

bhombot-ci bot commented Aug 3, 2021

@pawelbaran to confirm, the following checks are now queued:

  • copyright-compliance
  • dataset-compliance

@pawelbaran
Copy link
Member Author

@BHoMBot check ready-to-merge

@bhombot-ci
Copy link

bhombot-ci bot commented Aug 3, 2021

@pawelbaran to confirm, the following checks are now queued:

  • ready-to-merge

There are 3 requests in the queue ahead of you.

alelom
alelom reviewed Aug 4, 2021
View reviewed changes
Copy link
Member

@alelom alelom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple of minor suggestions

@pawelbaran pawelbaran requested a review from alelom August 4, 2021 08:50
alelom
alelom approved these changes Aug 4, 2021
View reviewed changes
Copy link
Member

@alelom alelom left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM; checked code only [edit: tested file also].

@bhombot-ci
Copy link

bhombot-ci bot commented Aug 4, 2021

@pawelbaran just to let you know, I have provided a check-installer result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @pawelbaran on BHoM

@bhombot-ci
Copy link

bhombot-ci bot commented Aug 4, 2021

@pawelbaran just to let you know, I have provided a check-versioning result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @pawelbaran on BHoM

@pawelbaran
Copy link
Member Author

@BHoMBot check compliance
@BHoMBot check core
@BHoMBot check null-handling
@BHoMBot check serialisation

@bhombot-ci
Copy link

bhombot-ci bot commented Aug 4, 2021

@pawelbaran to confirm, the following checks are now queued:

  • code-compliance
  • documentation-compliance
  • project-compliance
  • branch-compliance
  • dataset-compliance
  • copyright-compliance
  • core
  • null-handling
  • serialisation

@pawelbaran
Copy link
Member Author

@BHoMBot check ready-to-merge

1 similar comment
@pawelbaran
Copy link
Member Author

@BHoMBot check ready-to-merge

@bhombot-ci
Copy link

bhombot-ci bot commented Aug 4, 2021

@pawelbaran to confirm, the following checks are now queued:

  • ready-to-merge

@al-fisher al-fisher merged commit 1cd3cbf into master Aug 4, 2021
@al-fisher al-fisher deleted the BHoM-#1266-PersistentIdGetOnly branch August 4, 2021 13:41
@pawelbaran pawelbaran restored the BHoM-#1266-PersistentIdGetOnly branch August 4, 2021 15:12
@pawelbaran pawelbaran deleted the BHoM-#1266-PersistentIdGetOnly branch August 4, 2021 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alelom alelom alelom approved these changes

@al-fisher al-fisher Awaiting requested review from al-fisher al-fisher is a code owner

@FraserGreenroyd FraserGreenroyd Awaiting requested review from FraserGreenroyd FraserGreenroyd is a code owner

@rwemay rwemay Awaiting requested review from rwemay rwemay is a code owner

Assignees

@pawelbaran pawelbaran

Labels
type:compliance Non-conforming to code guidelines type:feature New capability or enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Refactoring of the RevitIdentifiers fragment
3 participants
@pawelbaran @alelom @al-fisher